From: Geert Uytterhoeven <geert@linux-m68k•org>
To: Sam Ravnborg <sam@ravnborg•org>
Cc: Greg Ungerer <gerg@snapgear•com>, Rob Landley <rob@landley•net>,
linux-kernel@vger•kernel.org, dwmw2@infradead•org,
linux-next@vger•kernel.org
Subject: Re: make headers_install broken for ARCH=m68k in 2.6.29-rc7.
Date: Fri, 13 Mar 2009 09:33:18 +0100 [thread overview]
Message-ID: <10f740e80903130133r130b8713v690437f0f38eb0b8@mail.gmail.com> (raw)
In-Reply-To: <20090313082555.GA19045@uranus.ravnborg.org>
On Fri, Mar 13, 2009 at 09:25, Sam Ravnborg <sam@ravnborg•org> wrote:
> On Fri, Mar 13, 2009 at 05:04:57PM +1000, Greg Ungerer wrote:
>> I pretty quick time I can fix up the last couple on the above list.
>> But do we want to put all that change into 2.6.29-rc at this point?
>
> In general we do not want to have headers_check broken in mainline,
headers_check is not broken, headers_install is.
Hmm, in some sense headers_check _is_ broken, as it doesn't notice
headers_install
installs headers that refer to other headers that are not installed...
> so if this is what is required to fix it then yes.
Yep, it's a regression from 2.6.28.
Greg, I had a quick look at your signcontext.h and signal.h merge, and the MMU
part seems to be OK.
However, some of the installed headers still have checks for CONFIG_MMU:
param.h:#ifdef CONFIG_MMU
sigcontext.h:#ifndef CONFIG_MMU
sigcontext.h:#ifdef CONFIG_MMU
siginfo.h:#ifdef CONFIG_MMU
siginfo.h:#ifdef CONFIG_MMU
siginfo.h:#endif /* CONFIG_MMU */
swab.h:#elif defined(CONFIG_MMU)
so these have to be added to the generic unifdef-y list (is that
include/asm-generic/Kbuild.asm?).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k•org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2009-03-13 8:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200903120437.03837.rob@landley.net>
[not found] ` <20090312095854.GA9398@uranus.ravnborg.org>
2009-03-12 20:03 ` make headers_install broken for ARCH=m68k in 2.6.29-rc7 Rob Landley
2009-03-12 20:58 ` Sam Ravnborg
2009-03-12 23:24 ` Stephen Rothwell
2009-03-12 21:02 ` Sam Ravnborg
2009-03-12 22:40 ` Geert Uytterhoeven
2009-03-13 3:25 ` Rob Landley
2009-03-13 7:04 ` Greg Ungerer
2009-03-13 8:25 ` Sam Ravnborg
2009-03-13 8:33 ` Geert Uytterhoeven [this message]
2009-03-13 8:59 ` Sam Ravnborg
2009-03-13 10:52 ` Greg Ungerer
2009-03-13 12:14 ` Geert Uytterhoeven
2009-03-16 12:40 ` Greg Ungerer
2009-03-16 20:20 ` Rob Landley
2009-03-16 22:08 ` Geert Uytterhoeven
2009-03-16 23:09 ` Greg Ungerer
2009-03-16 23:10 ` Greg Ungerer
2009-03-18 4:03 ` Rob Landley
2009-03-18 5:34 ` Greg Ungerer
2009-03-18 18:12 ` Rob Landley
2009-03-18 23:53 ` Greg Ungerer
2009-03-19 7:59 ` Geert Uytterhoeven
2009-03-19 8:41 ` Rob Landley
2009-03-13 8:25 ` Geert Uytterhoeven
2009-03-13 6:53 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10f740e80903130133r130b8713v690437f0f38eb0b8@mail.gmail.com \
--to=geert@linux-m68k$(echo .)org \
--cc=dwmw2@infradead$(echo .)org \
--cc=gerg@snapgear$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rob@landley$(echo .)net \
--cc=sam@ravnborg$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox