From: David Howells <dhowells@redhat•com>
To: Eric Biggers <ebiggers@kernel•org>
Cc: dhowells@redhat•com, Stephen Rothwell <sfr@canb•auug.org.au>,
linux-fscrypt@vger•kernel.org, linux-next@vger•kernel.org,
keyrings@vger•kernel.org
Subject: Re: Merge resolution for fscrypt and keyrings trees
Date: Thu, 15 Aug 2019 14:37:20 +0100 [thread overview]
Message-ID: <12089.1565876240@warthog.procyon.org.uk> (raw)
In-Reply-To: <20190814222822.GA101319@gmail.com>
Eric Biggers <ebiggers@kernel•org> wrote:
> +static struct key_acl fscrypt_keyring_acl = {
> + .usage = REFCOUNT_INIT(1),
> + .nr_ace = 2,
> + .aces = {
> + KEY_POSSESSOR_ACE(KEY_ACE_SEARCH | KEY_ACE_INVAL |
> + KEY_ACE_JOIN),
> + KEY_OWNER_ACE(KEY_ACE_SEARCH | KEY_ACE_INVAL | KEY_ACE_JOIN |
> + KEY_ACE_READ | KEY_ACE_VIEW),
> + }
> +};
Does you really want JOIN permission for these keyrings? Are you permitting
them to be used with KEYCTL_JOIN_SESSION_KEYRING? Do you also want INVAL for
the keyring rather than just the keys it contains? Would CLEAR be more
appropriate?
> +static struct key_acl fscrypt_key_acl = {
> + .usage = REFCOUNT_INIT(1),
> + .nr_ace = 2,
> + .aces = {
> + KEY_POSSESSOR_ACE(KEY_ACE_SEARCH | KEY_ACE_INVAL |
> + KEY_ACE_JOIN),
> + KEY_OWNER_ACE(KEY_ACE_SEARCH | KEY_ACE_INVAL | KEY_ACE_JOIN |
> + KEY_ACE_VIEW),
> + }
> +};
JOIN permission is useless here. This is only used for keys of type
key_type_fscrypt that I can see - and those aren't keyrings and so aren't
joinable.
> +static struct key_acl fscrypt_user_key_acl = {
Ditto.
David
next prev parent reply other threads:[~2019-08-15 13:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 22:28 Merge resolution for fscrypt and keyrings trees Eric Biggers
2019-08-15 13:37 ` David Howells [this message]
2019-08-15 16:24 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12089.1565876240@warthog.procyon.org.uk \
--to=dhowells@redhat$(echo .)com \
--cc=ebiggers@kernel$(echo .)org \
--cc=keyrings@vger$(echo .)kernel.org \
--cc=linux-fscrypt@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox