Subject: Re: [PATCH-next] pcmcia: fix sparse integer as NULL pointer warning

From: Harvey Harrison <[email-masked]>
Date: Wed, 23 Jul 2008 22:00:05 -0700

On Thu, 2008-07-24 at 14:36 +1000, Stephen Rothwell wrote:
> On Wed, 23 Jul 2008 18:34:08 -0700 Harvey Harrison <[email-masked]> wrote:
> >
> > +++ b/drivers/pcmcia/rsrc_nonstatic.c
> > @@ -275,7 +275,7 @@ static int readable(struct pcmcia_socket *s, struct resource *res,
> >  		destroy_cis_cache(s);
> >  	}
> >  	s->cis_mem.res = NULL;
> > -	if ((ret != 0) || (count == 0))
> > +	if ((ret != 0) || (count == NULL))
> 
> I was wondering if it should be
> 			   (*count == 0)
> 

Actually, it looks that way as in this case count can never be none.

readable() is only called in one place where it is passed the addresses
of two local variables.  Looking at pccard_validate_cis(), the number
of valid tuples found is returned through the info pointer, or zero
if invalid cis is found.

So I'd say *count == 0 is probably right.

Dominik?

Harvey