From: Johannes Berg <johannes@sipsolutions•net>
To: "John W. Linville" <linville@tuxdriver•com>
Cc: linux-wireless@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-next@vger•kernel.org,
Stephen Rothwell <sfr@canb•auug.org.au>,
Geert Uytterhoeven <geert@linux-m68k•org>
Subject: Re: [PATCH] mac80211: add explicit padding in struct ieee80211_tx_info
Date: Wed, 12 Nov 2008 18:08:44 +0100 [thread overview]
Message-ID: <1226509724.14186.14.camel@johannes.berg> (raw)
In-Reply-To: <1226502337-11085-1-git-send-email-linville@tuxdriver.com>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
On Wed, 2008-11-12 at 10:05 -0500, John W. Linville wrote:
> Otherwise, the BUILD_BUG_ON calls in ieee80211_tx_info_clear_status can
> fail on some architectures.
>
> Signed-off-by: John W. Linville <linville@tuxdriver•com>
> ---
> Why do we have those BUILD_BUG_ON calls anyway? Hmmm...
Because we actually use those offsets in places to clear things.
> include/net/mac80211.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
> index feb52cc..38302d6 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -333,6 +333,7 @@ struct ieee80211_tx_info {
> u8 antenna_sel_tx;
>
> /* 2 byte hole */
> + u8 pad[2];
>
> union {
> struct {
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-11-12 17:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 7:28 linux-next: Tree for November 12 Stephen Rothwell
2008-11-12 7:56 ` mac80211.h (was: Re: linux-next: Tree for November 12) Geert Uytterhoeven
2008-11-12 15:05 ` [PATCH] mac80211: add explicit padding in struct ieee80211_tx_info John W. Linville
2008-11-12 17:08 ` Johannes Berg [this message]
2008-11-12 9:11 ` linux-next: Tree for November 12 - lguest build failure Kamalesh Babulal
2008-11-12 10:40 ` Rusty Russell
2008-11-12 12:26 ` [Lguest] " Rusty Russell
2008-11-12 21:01 ` [PATCH linux-next] : Tree for November 12 (libcrc32c) Randy Dunlap
2008-11-13 14:09 ` Herbert Xu
2008-11-12 21:05 ` [PATCH linux-next 3rd time] 9p: restrict RDMA usage Randy Dunlap
2008-11-12 21:10 ` linux-next: Tree for November 12 (ipw2200 build error) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226509724.14186.14.camel@johannes.berg \
--to=johannes@sipsolutions$(echo .)net \
--cc=geert@linux-m68k$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linville@tuxdriver$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox