Subject: Re: linux-next: Tree for November 19 (mtd build error)

From: Ben Hutchings <[email-masked]>
Date: Wed, 19 Nov 2008 19:18:07 +0000

On Wed, 2008-11-19 at 11:06 -0800, Randy Dunlap wrote:
> David Woodhouse wrote:
> > On Wed, 2008-11-19 at 10:53 -0800, Randy Dunlap wrote:
> >> On Wed, 19 Nov 2008 17:59:17 +1100 Stephen Rothwell wrote:
> >>
> >> (.text+0x104879): undefined reference to `add_mtd_device'
> >> (.text+0x1048e1): undefined reference to `del_mtd_device'
> >> mtd.c:(.text+0x104999): undefined reference to `mtd_erase_callback'
> >>
> >>
> >> config attached.
> > 
> > CONFIG_SFC_MTD=y
> > 
> > What's that?
> 
> drivers/net/sfc/Kconfig:
> 
> config SFC_MTD
> 	bool "Solarflare Solarstorm SFC4000 flash MTD support"
> 	depends on SFC && MTD
> 	default y
> 	help
> 	  This exposes the on-board flash memory as an MTD device (e.g.
>           /dev/mtd1).  This makes it possible to upload new boot code
>           to the NIC.
> 
> 
> sfc people added to cc.

Please use the address [email-masked], as listed in
MAINTAINERS.  There are several of us working on the driver, and they
no longer include Michael Brown.

David Woodhouse wrote:
> Sounds like this was built-in while CONFIG_MTD=m

So does the dependency need to be something like
"depends on SFC && MTD && !(SFC=y && MTD=m)"?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.