public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: "Eilon Greenstein" <eilong@broadcom•com>
To: David Miller <davem@davemloft•net>
Cc: "sfr@canb•auug.org.au" <sfr@canb•auug.org.au>,
	"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
	"steve.glendinning@smsc•com" <steve.glendinning@smsc•com>,
	Yaniv Rosner <yaniv.rosner@broadcom•com>
Subject: Re: linux-next: net tree build warnings
Date: Wed, 17 Dec 2008 10:04:43 +0200	[thread overview]
Message-ID: <1229501083.28117.2.camel@lb-tlvb-eliezer> (raw)
In-Reply-To: <20081216.235355.139378362.davem@davemloft.net>

On Tue, 2008-12-16 at 23:53 -0800, David Miller wrote:
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Wed, 17 Dec 2008 18:22:24 +1100
> 
> > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> >
> > In file included from drivers/net/bnx2x_main.c:58:
> > drivers/net/bnx2x_link.h:30:1: warning: "FLOW_CTRL_TX" redefined
> > In file included from drivers/net/bnx2x_main.c:40:
> > include/linux/mii.h:139:1: warning: this is the location of the previous definition
> > In file included from drivers/net/bnx2x_main.c:58:
> > drivers/net/bnx2x_link.h:31:1: warning: "FLOW_CTRL_RX" redefined
> > In file included from drivers/net/bnx2x_main.c:40:
> > include/linux/mii.h:140:1: warning: this is the location of the previous definition
> >
> > Caused by commit e18ce3465477502108187c6c08b6423fb784a313 ("net: Move flow control definitions to mii.h").
> > --
> 
> Thanks, I'll fix this up with the following two commits:
> 
....

> --------------------
> bnx2x: Fix namespace collision with FLOW_CTRL_{TX,RX}
> 
> These are now defined in linux/mii.h and the bnx2x driver
> defines different values which are shared with hardware
> data structures.
> 
> So add a "BNX2X_" prefix to these macro names.
> 
> Based upon a report from Stephen Rothwell.
> 
> Signed-off-by: David S. Miller <davem@davemloft•net>
> ---
>  drivers/net/bnx2x_link.c |   72 +++++++++++++++++++++++-----------------------
>  drivers/net/bnx2x_link.h |   10 +++---
>  drivers/net/bnx2x_main.c |   38 ++++++++++++------------
>  3 files changed, 60 insertions(+), 60 deletions(-)

Thanks Dave - I was just writing the email header for the exact same
fix ;)
Funny how we both miraculously chose the same prefix...

Thanks,
Eilon

next prev parent reply	other threads:[~2008-12-17  8:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-17  7:22 linux-next: net tree build warnings Stephen Rothwell
2008-12-17  7:53 ` David Miller
2008-12-17  8:04   ` Eilon Greenstein [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-03-16  6:03 Stephen Rothwell
2009-03-16  6:05 ` Dhananjay Phadke
2009-03-26  6:37 Stephen Rothwell
2009-03-26  7:50 ` Eric Leblond
2009-03-26 13:17   ` Patrick McHardy
2009-03-26 22:01   ` Stephen Rothwell
2009-04-29  4:59 Stephen Rothwell
2009-04-29  6:02 ` David Miller
2009-04-30  0:54   ` David Miller
2009-04-30  7:06     ` Stephen Rothwell
2009-06-11  4:55 Stephen Rothwell
2009-06-11  6:47 ` David Miller
2009-06-11  7:20   ` Stephen Rothwell
2009-09-04  4:34 Stephen Rothwell
2009-09-04  4:35 ` David Miller
2009-10-14  4:20 Stephen Rothwell
2009-10-14  4:34 ` Stephen Rothwell
2009-10-14 22:11   ` David Miller
2009-10-15  1:55     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229501083.28117.2.camel@lb-tlvb-eliezer \
    --to=eilong@broadcom$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    --cc=steve.glendinning@smsc$(echo .)com \
    --cc=yaniv.rosner@broadcom$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox