From: "Simon Holm Thøgersen" <odie@cs•aau.dk>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
akpm <akpm@linux-foundation•org>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
linux-ext4@vger•kernel.org
Subject: Re: [PATCH -next] jbd2: fix printk format warning
Date: Sun, 11 Jan 2009 19:52:53 +0100 [thread overview]
Message-ID: <1231699973.17759.22.camel@odie.local> (raw)
In-Reply-To: <20090105121158.94d990c3.randy.dunlap@oracle.com>
man, 05 01 2009 kl. 12:11 -0800, skrev Randy Dunlap:
> From: Randy Dunlap <randy.dunlap@oracle•com>
>
> Fix jbd2 printk format:
>
> fs/jbd2/journal.c:848: warning: format '%lu' expects type 'long unsigned int',
> but argument 3 has type 'uint32_t'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
> ---
> fs/jbd2/journal.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-next-20090105.orig/fs/jbd2/journal.c
> +++ linux-next-20090105/fs/jbd2/journal.c
> @@ -845,7 +845,8 @@ static int jbd2_seq_info_show(struct seq
> seq_printf(seq, " %ums logging transaction\n",
> jiffies_to_msecs(s->stats->u.run.rs_logging / s->stats->ts_tid));
> seq_printf(seq, " %luus average transaction commit time\n",
> - do_div(s->journal->j_average_commit_time, 1000));
> + (unsigned long)do_div(s->journal->j_average_commit_time,
> + 1000));
> seq_printf(seq, " %lu handles per transaction\n",
> s->stats->u.run.rs_handle_count / s->stats->ts_tid);
> seq_printf(seq, " %lu blocks per transaction\n",
This patch is just as wrong as the original code. Please don't
apply it, but see my "[PATCH] jbd2: fix wrong use of do_div"
that I just sent out.
Simon Holm Thøgersen
next prev parent reply other threads:[~2009-01-11 18:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 6:35 linux-next: Tree for January 5 Stephen Rothwell
2009-01-05 17:45 ` linux-next: Tree for January 5 (dm-target) Randy Dunlap
2009-01-06 3:45 ` Cheng Renquan
2009-01-05 20:04 ` linux-next: Tree for January 5 (multimedia build errors) Randy Dunlap
2009-01-06 11:35 ` Mauro Carvalho Chehab
2009-01-05 20:06 ` linux-next: Tree for January 5 (multimedia #2) Randy Dunlap
2009-01-06 11:39 ` Mauro Carvalho Chehab
2009-01-05 20:09 ` linux-next: Tree for January 5 (multimedia #3) Randy Dunlap
2009-01-07 0:36 ` Mauro Carvalho Chehab
2009-01-07 18:34 ` Randy Dunlap
2009-01-07 23:27 ` Mauro Carvalho Chehab
2009-01-07 23:36 ` Randy Dunlap
2009-01-05 20:11 ` [PATCH -next] jbd2: fix printk format warning Randy Dunlap
2009-01-11 18:52 ` Simon Holm Thøgersen [this message]
2009-01-11 19:07 ` Randy Dunlap
2009-01-11 19:20 ` Simon Holm Thøgersen
2009-01-05 21:41 ` dm_attr_{name,uuid}_show buffer overflow? (was: Re: linux-next: Tree for January 5) Geert Uytterhoeven
2009-01-05 22:18 ` strncat() misuse (was: Re: dm_attr_{name,uuid}_show buffer overflow? (was: Re: linux-next: Tree for January 5)) Geert Uytterhoeven
2009-01-06 1:27 ` Alasdair G Kergon
2009-01-06 2:16 ` Alasdair G Kergon
2009-01-07 14:39 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231699973.17759.22.camel@odie.local \
--to=odie@cs$(echo .)aau.dk \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-ext4@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox