Subject: Re: [BUILD_FAILURE] next-20090115 - s390x - mm/kmemleak.c

From: Catalin Marinas <[email-masked]>
Date: Thu, 15 Jan 2009 12:16:21 +0000

On Thu, 2009-01-15 at 13:13 +0100, Heiko Carstens wrote:
> On Thu, Jan 15, 2009 at 02:08:00PM +0200, Pekka Enberg wrote:
> > On Thu, 2009-01-15 at 11:55 +0000, Catalin Marinas wrote:
> > > On Thu, 2009-01-15 at 12:20 +0100, Heiko Carstens wrote:
> > > > On Thu, Jan 15, 2009 at 04:05:04PM +0530, Kamalesh Babulal wrote:
> > > > > Hi Stephen,
> > > > > 
> > > > > 	next-20090115 allyesconfig build fails on s390x
> > > > > 
> > > > > mm/built-in.o: In function `kmemleak_scan':
> > > > > mm/kmemleak.c:977: undefined reference to `_sdata'
> > > > > make: *** [.tmp_vmlinux1] Error 1
> > > > 
> > > > A lot of architectures don't have _sdata definined in their linker scripts.
> > > > On s390 _sdata would be the same as _etext. But that is not necessarily true
> > > > for all architectures.
> > > 
> > > Kmemleak has only been tested on ARM and x86. I can add patches for the
> > > other architectures so that the compilation is fine but can't really run
> > > such kernels.
> > 
> > Yeah, but you could just depend on X86 || ARM in Kconfig, no?
> 
> CONFIG_HAVE_KMEMLEAK_SUPPORT ?
> Is there actually more arch specific that needs to be done?
> Haven't checked yet.

Not in the latter kmemleak versions, just the vmlinux.lds _sdata,
_edata, __bss_start, __bss_stop entries.

-- 
Catalin