From: Trond Myklebust <Trond.Myklebust@netapp•com>
To: Paul Mundt <lethal@linux-sh•org>
Cc: Benny Halevy <bhalevy@panasas•com>,
Rusty Russell <rusty@rustcorp•com.au>,
Ingo Molnar <mingo@elte•hu>,
linux-next@vger•kernel.org, Andy Adamson <andros@netapp•com>,
Fredric Isaman <iisaman@citi•umich.edu>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Alexander Beregalov <a.beregalov@gmail•com>,
Subrata Modak <subrata@linux•vnet.ibm.com>,
sachinp <sachinp@linux•vnet.ibm.com>
Subject: Re: [PATCH -next] lib: Move find_last_bit.o to obj-y to enable use by modules.
Date: Thu, 23 Apr 2009 12:38:50 -0400 [thread overview]
Message-ID: <1240504730.11148.13.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <20090423141237.GA27102@linux-sh.org>
On Thu, 2009-04-23 at 23:12 +0900, Paul Mundt wrote:
> On Thu, Apr 23, 2009 at 09:59:28AM -0400, Trond Myklebust wrote:
> > On Thu, 2009-04-23 at 22:25 +0900, Paul Mundt wrote:
> > > > In any case, this patch does not belong in the NFS tree since it touches
> > > > generic library code, not NFS code. Benny, if nobody else wants to
> > > > shepherd it, then just send it directly to Linus.
> > > >
> > > That's a complete cop-out, if there had been no export at all how would
> > > you have proceeded? How is this situation any different?
> >
> > Please see Documentation/SubmittingPatches. If we were requesting a new
> > kernel feature, I'd go looking for the maintainer and get an ACK or get
> > said maintainer to include the patch in their tree.
> >
> > As it is, said kernel feature exists, but is broken. The correct thing
> > to do is to fix the kernel feature. Sooner, rather than later.
> >
> And until that feature is working, you have absolutely no business
> merging crap in to the kernel that uses it. You made an assumption that
> it was working, which turned out to be wrong (which you also failed to
> validate through any form of testing), and subsequently caused a
> regression. Mistakes happen and are expected in -next, refusing to deal
> with them at all on the other hand..
>
> The first course of action any responsible maintainer would have taken
> would be to revert the offending changeset once the issue was pointed out
> until its dependencies were sorted out. Not only have you failed to do
> that, you couldn't even be bothered replying to the email with patch that
> pointed out the build failure in the first place. This created the
> mistaken conclusion that you were actually doing something about the
> regression you caused rather than just dismissing it out of hand.
>
> The nfs tree should be dropped on the floor immediately until this issue
> is resolved.
Whatever...
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp•com
www.netapp.com
next prev parent reply other threads:[~2009-04-23 16:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 3:07 [PATCH -next] lib: Move find_last_bit.o to obj-y to enable use by modules Paul Mundt
2009-04-16 8:11 ` Benny Halevy
2009-04-23 6:50 ` Paul Mundt
2009-04-23 10:12 ` Benny Halevy
2009-04-23 10:29 ` Paul Mundt
2009-04-23 12:59 ` Trond Myklebust
2009-04-23 13:18 ` Benny Halevy
2009-04-23 13:25 ` Paul Mundt
2009-04-23 13:59 ` Trond Myklebust
2009-04-23 14:12 ` Paul Mundt
2009-04-23 16:38 ` Trond Myklebust [this message]
2009-04-26 12:49 ` Rusty Russell
2009-04-26 16:42 ` Ingo Molnar
2009-04-26 17:29 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240504730.11148.13.camel@heimdal.trondhjem.org \
--to=trond.myklebust@netapp$(echo .)com \
--cc=a.beregalov@gmail$(echo .)com \
--cc=andros@netapp$(echo .)com \
--cc=bhalevy@panasas$(echo .)com \
--cc=iisaman@citi$(echo .)umich.edu \
--cc=lethal@linux-sh$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=rusty@rustcorp$(echo .)com.au \
--cc=sachinp@linux$(echo .)vnet.ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=subrata@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox