Subject: Re: Next May 13:[drivers/base/firmware*] Bug while booting on x86

From: David Woodhouse <[email-masked]>
Date: Thu, 14 May 2009 16:54:27 +0100

On Wed, 2009-05-13 at 18:36 +0530, Sachin Sant wrote:
> BUG: unable to handle kernel NULL pointer dereference at 0000050c
> IP: [<c0119c5d>] kunmap+0x33/0x59

Oops. Does this fix it?

--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -328,7 +328,7 @@ firmware_data_write(struct kobject *kobj, struct
bin_attribute *bin_attr,
 
 		memcpy(page_data + page_ofs, buffer, page_cnt);
 
-		kunmap(page_data);
+		kunmap(fw_priv->pages[page_nr]);
 		buffer += page_cnt;
 		offset += page_cnt;
 		count -= page_cnt;

-- 
David Woodhouse                            Open Source Technology Centre
[email-masked]                              Intel Corporation