public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions•net>
To: "Gábor Stefanik" <netrolller.3d@gmail•com>
Cc: Randy Dunlap <randy.dunlap@oracle•com>,
	Stephen Rothwell <sfr@canb•auug.org.au>,
	linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
	"linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>
Subject: Re: linux-next: Tree for June 3 (rfkill)
Date: Wed, 03 Jun 2009 17:53:37 +0200	[thread overview]
Message-ID: <1244044417.4862.23.camel@johannes.local> (raw)
In-Reply-To: <69e28c910906030847k7e6f97bbo16497d872b93151b@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

On Wed, 2009-06-03 at 17:47 +0200, Gábor Stefanik wrote:

> >> CFG80211=y
> >> MAC80211=y
> >> RFKILL=m
> >>
> >> net/built-in.o: In function `cfg80211_netdev_notifier_call':
> >> core.c:(.text+0xa678b): undefined reference to `rfkill_blocked'
> >> net/built-in.o: In function `cfg80211_dev_free':
> >
> > Hrm. I thought
> >
> > config CFG80211
> >        tristate "Improved wireless configuration API"
> >        depends on RFKILL || !RFKILL
> >
> > would avoid that. Why doesn't it?
> >
> > johannes
> >
> 
> Maybe the "y" state of CFG80211 specifically needs to depend on
> RFKILL=y || !RFKILL.

Maybe doesn't help me at all.

> BTW should CFG80211=y really be blocked when RFKILL=m? 

Yes.

> Shouldn't we
> just disable CFG80211 RFKILL support in this case (perhaps via a
> separate CONFIG_CFG80211_RFKILL automatically configured depending on
> CONFIG_RFKILL)?

That would be immensely stupid. You might as well just make cfg80211 a
module then.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2009-06-03 15:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-03  9:09 linux-next: Tree for June 3 Stephen Rothwell
2009-06-03 15:22 ` linux-next: Tree for June 3 (rfkill) Randy Dunlap
2009-06-03 15:29   ` Johannes Berg
     [not found]     ` <1244042950.4862.10.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-06-03 15:47       ` Gábor Stefanik
2009-06-03 15:53         ` Johannes Berg [this message]
     [not found]   ` <4A269539.8020607-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-06-03 16:27     ` Johannes Berg
2009-06-03 17:20   ` Randy Dunlap
2009-06-03 17:33     ` Johannes Berg
     [not found]       ` <1244050400.22105.0.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-06-03 22:48         ` Inaky Perez-Gonzalez
2009-06-03 15:24 ` linux-next: Tree for June 3 (staging) Randy Dunlap
2009-06-03 15:25   ` Greg KH
2009-06-03 15:40     ` Randy Dunlap
2009-06-03 23:11       ` Greg KH
2009-06-04  2:04         ` Gao, Yunpeng
2009-06-03 15:44 ` linux-next: Tree for June 3 (staging++) Randy Dunlap
2009-06-03 15:50 ` linux-next: Tree for June 3 (driver core) Randy Dunlap
2009-06-03 21:22   ` Greg KH
2009-06-03 21:44     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244044417.4862.23.camel@johannes.local \
    --to=johannes@sipsolutions$(echo .)net \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=linux-wireless@vger$(echo .)kernel.org \
    --cc=netrolller.3d@gmail$(echo .)com \
    --cc=randy.dunlap@oracle$(echo .)com \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox