Subject: Re: [PATCH -next] bnx2i/cnic: kconfig interactions

From: "Michael Chan" <[email-masked]>
Date: Thu, 18 Jun 2009 11:39:21 -0700

On Thu, 2009-06-18 at 09:55 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <[email-masked]>
> 
> NETDEVICES + NETDEV_1000 need to be enabled so that kconfig will check
> those branches for selects and enforce "select UIO" under CNIC.
> Otherwise the build fails with:

I think this patch is better than your previous patch to select UIO.
Other iSCSI drivers that select net drivers will probably need something
similar too.

Thanks.
Acked-by: Michael Chan <[email-masked]>

> 
> ERROR: "uio_unregister_device" [drivers/net/cnic.ko] undefined!
> ERROR: "uio_event_notify" [drivers/net/cnic.ko] undefined!
> ERROR: "__uio_register_device" [drivers/net/cnic.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <[email-masked]>
> Cc: Sam Ravnborg <[email-masked]>
> Cc: Anil Veerabhadrappa <[email-masked]>
> Cc: Michael Chan <[email-masked]>
> ---
>  drivers/scsi/bnx2i/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- linux-next-20090618.orig/drivers/scsi/bnx2i/Kconfig
> +++ linux-next-20090618/drivers/scsi/bnx2i/Kconfig
> @@ -1,6 +1,8 @@
>  config SCSI_BNX2_ISCSI
>  	tristate "Broadcom NetXtreme II iSCSI support"
>  	select SCSI_ISCSI_ATTRS
> +	select NETDEVICES
> +	select NETDEV_1000
>  	select CNIC
>  	depends on PCI
>  	---help---
> 
> 
>