From: Dan Williams <dan.j.williams@intel•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: "linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: async_tx tree build failure
Date: Wed, 22 Jul 2009 21:33:40 -0700 [thread overview]
Message-ID: <1248323620.24951.2.camel@dwillia2-linux.ch.intel.com> (raw)
In-Reply-To: <20090723120004.fac867eb.sfr@canb.auug.org.au>
On Wed, 2009-07-22 at 19:00 -0700, Stephen Rothwell wrote:
> Hi Dan,
>
> Since next-20090623, the linux-next build (i386 allmodconfig) has failed
> like this:
>
> crypto/async_tx/async_xor.c: In function ‘async_xor_init’:
> crypto/async_tx/async_xor.c:310: error: size of array ‘type name’ is negative
>
> The failing line is this:
>
> BUILD_BUG_ON(sizeof(dma_addr_t) > sizeof(struct page *));
>
> in async_xor_init() introduced by commit
> 0036731c88fdb5bf4f04a796a30b5e445fc57f54 ("async_tx: kill tx_set_src and
> tx_set_dest methods") in Feb, 2008.
>
> Bisecting in the next-20090623 tree pointed to commit
> 3c30a9ca1fb95214e60e3bf43957971df6668033 ("dmaengine: move HIGHMEM64G
> restriction to ASYNC_TX_DMA") from the async_tx tree. This is now commit
> f3c56e57f66a73a241299dbec1ad55491aa0e403.
Gah, yes that commit was half baked. I have pushed out an updated tree
with the following fix:
diff --git a/crypto/async_tx/async_xor.c b/crypto/async_tx/async_xor.c
index 95fe2c8..90dd3f8 100644
--- a/crypto/async_tx/async_xor.c
+++ b/crypto/async_tx/async_xor.c
@@ -300,7 +300,7 @@ EXPORT_SYMBOL_GPL(async_xor_zero_sum);
static int __init async_xor_init(void)
{
- #ifdef CONFIG_DMA_ENGINE
+ #ifdef CONFIG_ASYNC_TX_DMA
/* To conserve stack space the input src_list (array of page pointers)
* is reused to hold the array of dma addresses passed to the driver.
* This conversion is only possible when dma_addr_t is less than the
Thanks,
Dan
next prev parent reply other threads:[~2009-07-23 4:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 2:00 linux-next: async_tx tree build failure Stephen Rothwell
2009-07-23 4:33 ` Dan Williams [this message]
2009-07-23 5:17 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2009-09-07 3:08 Stephen Rothwell
2009-09-09 1:35 ` Dan Williams
2009-09-09 1:41 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248323620.24951.2.camel@dwillia2-linux.ch.intel.com \
--to=dan.j.williams@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox