From: James Bottomley <James.Bottomley@HansenPartnership•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Jayamohan Kallickal <jayamohank@serverengines•com>,
Mike Christie <michaelc@cs•wisc.edu>,
linux-scsi <linux-scsi@vger•kernel.org>
Subject: Re: linux-next: scsi-post-merge tree build failure
Date: Tue, 08 Sep 2009 10:48:43 -0500 [thread overview]
Message-ID: <1252424923.3990.204.camel@mulgrave.site> (raw)
In-Reply-To: <20090908181221.e8f98215.sfr@canb.auug.org.au>
On Tue, 2009-09-08 at 18:12 +1000, Stephen Rothwell wrote:
> Hi James,
>
> On Mon, 7 Sep 2009 20:06:46 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> >
> > Today's linux-next build (powerpc allyesconfig) failed like this:
> >
> > drivers/scsi/be2iscsi/be_main.c: In function 'hwi_write_buffer':
> > drivers/scsi/be2iscsi/be_main.c:1481: error: implicit declaration of function 'virt_to_bus'
> >
> > Caused by commit 9316dc3deb9675c674f96a0c6fb74ccc6c497fae ("[SCSI]
> > be2iscsi: add 10Gbps iSCSI - BladeEngine 2 driver") which I have reverted
> > for today.
>
> The driver needs to depend on CONFIG_VIRT_TO_BUS if it needs to use
> virt_to_bus(). That will prevent it from building on some platforms
> (like powerpc) that do not implement virt_to_bus() and its brothers.
Actually, this is a modern hardware iSCSI card not some legacy piece of
hardware: it needs to use the proper API for this.
James
next prev parent reply other threads:[~2009-09-08 15:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-07 10:06 linux-next: scsi-post-merge tree build failure Stephen Rothwell
2009-09-08 8:12 ` Stephen Rothwell
2009-09-08 15:48 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-12-22 14:25 Stephen Rothwell
2008-12-22 14:51 ` Stephen Rothwell
2008-12-22 20:56 ` Benjamin Herrenschmidt
2008-12-11 8:27 Stephen Rothwell
2008-12-11 8:28 ` Stephen Rothwell
2008-12-11 12:35 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252424923.3990.204.camel@mulgrave.site \
--to=james.bottomley@hansenpartnership$(echo .)com \
--cc=jayamohank@serverengines$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=michaelc@cs$(echo .)wisc.edu \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox