From: Eric Dumazet <eric.dumazet@gmail•com>
To: Randy Dunlap <randy.dunlap@oracle•com>,
David Miller <davem@davemloft•net>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
netdev <netdev@vger•kernel.org>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: Tree for April 7 (net/core/dev_addr_lists)
Date: Wed, 07 Apr 2010 19:38:09 +0200 [thread overview]
Message-ID: <1270661889.8141.45.camel@edumazet-laptop> (raw)
In-Reply-To: <20100407095845.f29ebf48.randy.dunlap@oracle.com>
Le mercredi 07 avril 2010 à 09:58 -0700, Randy Dunlap a écrit :
> On Wed, 7 Apr 2010 17:41:23 +1000 Stephen Rothwell wrote:
>
> > Hi all,
> >
> > Changes since 20100401:
>
>
> when CONFIG_PROC_FS is disabled:
>
> linux-next-20100407/net/core/dev_addr_lists.c: In function 'dev_mc_net_init':
> linux-next-20100407/net/core/dev_addr_lists.c:722: error: implicit declaration of function 'proc_net_fops_create'
> linux-next-20100407/net/core/dev_addr_lists.c:722: error: 'dev_mc_seq_fops' undeclared (first use in this function)
> linux-next-20100407/net/core/dev_addr_lists.c:722: error: (Each undeclared identifier is reported only once
> linux-next-20100407/net/core/dev_addr_lists.c:722: error: for each function it appears in.)
> linux-next-20100407/net/core/dev_addr_lists.c: In function 'dev_mc_net_exit':
> linux-next-20100407/net/core/dev_addr_lists.c:729: error: implicit declaration of function 'proc_net_remove'
> make[3]: *** [net/core/dev_addr_lists.o] Error 1
>
> ---
> ~Randy
Thanks Randy, this should correct this
[PATCH net-next-2.6] net: include linux/proc_fs.h in dev_addr_lists.c
As pointed by Randy Dunlap, we must include linux/proc_fs.h in
net/core/dev_addr_lists.c, regardless of CONFIG_PROC_FS
Reported-by: Randy Dunlap <randy.dunlap@oracle•com>,
Signed-off-by: Eric Dumazet <eric.dumazet@gmail•com>
---
diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c
index 37d5975..508f9c1 100644
--- a/net/core/dev_addr_lists.c
+++ b/net/core/dev_addr_lists.c
@@ -14,6 +14,7 @@
#include <linux/netdevice.h>
#include <linux/rtnetlink.h>
#include <linux/list.h>
+#include <linux/proc_fs.h>
/*
* General list handling functions
@@ -667,7 +668,6 @@ void dev_mc_init(struct net_device *dev)
EXPORT_SYMBOL(dev_mc_init);
#ifdef CONFIG_PROC_FS
-#include <linux/proc_fs.h>
#include <linux/seq_file.h>
static int dev_mc_seq_show(struct seq_file *seq, void *v)
next prev parent reply other threads:[~2010-04-07 17:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 7:41 linux-next: Tree for April 7 Stephen Rothwell
2010-04-07 16:58 ` linux-next: Tree for April 7 (net/core/dev_addr_lists) Randy Dunlap
2010-04-07 17:38 ` Eric Dumazet [this message]
2010-04-07 17:50 ` Randy Dunlap
2010-04-07 23:46 ` David Miller
2010-04-07 17:15 ` linux-next: Tree for April 7 (other build fixes) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270661889.8141.45.camel@edumazet-laptop \
--to=eric.dumazet@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox