From: Trond Myklebust <trond.myklebust-41N18TsMXrtuMpJDpNschA@public•gmane.org>
To: Randy Dunlap
<randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public•gmane.org>,
"J. Bruce Fields"
<bfields-uC3wQj2KruNg9hUCZPvPmw@public•gmane.org>
Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public•gmane.org>,
linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: Re: linux-next: Tree for August 9 (nfs)
Date: Tue, 17 Aug 2010 17:23:28 -0400 [thread overview]
Message-ID: <1282080208.12506.7.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <4C643136.5090808-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
On Thu, 2010-08-12 at 10:36 -0700, Randy Dunlap wrote:
> On 08/12/10 10:31, Trond Myklebust wrote:
> > On Thu, 2010-08-12 at 09:18 -0700, Randy Dunlap wrote:
> >> On Mon, 9 Aug 2010 10:08:56 -0700 Randy Dunlap wrote:
> >>
> >> ping??
> >
> > Hi Randy,
> >
> > I'm sorry. A heavy travel schedule is affecting my response time at the
> > moment. I'll try to take care of this by Tuesday (when I get back home)
> > if not before.
>
> No problem. Just wanted to make sure that it's not lost.
Hi Randy,
How about the following fix?
Cheers
Trond
------------------------------------------------------------------------------------
Subject: [PATCH] NFS: Fix the selection of security flavours in Kconfig
From: Trond Myklebust <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public•gmane.org>
Randy Dunlap reports:
ERROR: "svc_gss_principal" [fs/nfs/nfs.ko] undefined!
because in fs/nfs/Kconfig, NFS_V4 selects RPCSEC_GSS_KRB5
and/or in fs/nfsd/Kconfig, NFSD_V4 selects RPCSEC_GSS_KRB5.
RPCSEC_GSS_KRB5 does 5 selects, but none of these is enforced/followed
by the fs/nfs[d]/Kconfig configs:
select SUNRPC_GSS
select CRYPTO
select CRYPTO_MD5
select CRYPTO_DES
select CRYPTO_CBC
Reported-by: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public•gmane.org>
Cc: J. Bruce Fields <bfields-uC3wQj2KruNg9hUCZPvPmw@public•gmane.org>
Signed-off-by: Trond Myklebust <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public•gmane.org>
---
fs/nfs/Kconfig | 1 -
fs/nfsd/Kconfig | 1 -
net/sunrpc/Kconfig | 9 +++++----
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
index cc1bb33..2ddc384 100644
--- a/fs/nfs/Kconfig
+++ b/fs/nfs/Kconfig
@@ -63,7 +63,6 @@ config NFS_V3_ACL
config NFS_V4
bool "NFS client support for NFS version 4"
depends on NFS_FS
- select RPCSEC_GSS_KRB5
help
This option enables support for version 4 of the NFS protocol
(RFC 3530) in the kernel's NFS client.
diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
index 503b9da..95932f5 100644
--- a/fs/nfsd/Kconfig
+++ b/fs/nfsd/Kconfig
@@ -69,7 +69,6 @@ config NFSD_V4
depends on NFSD && PROC_FS && EXPERIMENTAL
select NFSD_V3
select FS_POSIX_ACL
- select RPCSEC_GSS_KRB5
help
This option enables support in your system's NFS server for
version 4 of the NFS protocol (RFC 3530).
diff --git a/net/sunrpc/Kconfig b/net/sunrpc/Kconfig
index 443c161..3376d76 100644
--- a/net/sunrpc/Kconfig
+++ b/net/sunrpc/Kconfig
@@ -18,10 +18,11 @@ config SUNRPC_XPRT_RDMA
If unsure, say N.
config RPCSEC_GSS_KRB5
- tristate "Secure RPC: Kerberos V mechanism (EXPERIMENTAL)"
- depends on SUNRPC && EXPERIMENTAL
+ tristate
+ depends on SUNRPC && CRYPTO
+ prompt "Secure RPC: Kerberos V mechanism" if !(NFS_V4 || NFSD_V4)
+ default y
select SUNRPC_GSS
- select CRYPTO
select CRYPTO_MD5
select CRYPTO_DES
select CRYPTO_CBC
@@ -34,7 +35,7 @@ config RPCSEC_GSS_KRB5
available from http://linux-nfs.org/. In addition, user-space
Kerberos support should be installed.
- If unsure, say N.
+ If unsure, say Y.
config RPCSEC_GSS_SPKM3
tristate "Secure RPC: SPKM3 mechanism (EXPERIMENTAL)"
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-08-17 21:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 3:23 linux-next: Tree for August 9 Stephen Rothwell
2010-08-09 17:08 ` linux-next: Tree for August 9 (nfs) Randy Dunlap
[not found] ` <20100809100856.b03a9bc1.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2010-08-12 16:18 ` Randy Dunlap
[not found] ` <20100812091842.6a3b84b9.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2010-08-12 17:31 ` Trond Myklebust
2010-08-12 17:36 ` Randy Dunlap
[not found] ` <4C643136.5090808-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2010-08-17 21:23 ` Trond Myklebust [this message]
[not found] ` <1282080208.12506.7.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2010-08-17 21:39 ` Randy Dunlap
2010-08-09 17:55 ` [patch -NEXT] usb/gadget/webcam: fix Kconfig depends again Randy Dunlap
2010-08-10 12:16 ` Laurent Pinchart
2010-08-10 14:48 ` Randy Dunlap
[not found] ` <4C6166D9.60607-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2010-08-10 14:53 ` Laurent Pinchart
[not found] ` <201008101653.08358.laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2010-08-17 18:03 ` Randy Dunlap
2010-08-09 17:56 ` [PATCH -next] v4l2-ctrls.c: needs to include slab.h Randy Dunlap
2010-08-11 18:45 ` Tony Vroon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282080208.12506.7.camel@heimdal.trondhjem.org \
--to=trond.myklebust-41n18tsmxrtumpjdpnscha@public$(echo .)gmane.org \
--cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox