From: Trond Myklebust <Trond.Myklebust@netapp•com>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
akpm <akpm@linux-foundation•org>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
linux-nfs@vger•kernel.org
Subject: Re: [PATCH -next] nfs: include ratelimit.h, fix nfs4state build error
Date: Sat, 23 Oct 2010 10:09:06 -0400 [thread overview]
Message-ID: <1287842947.3022.7.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <20101022161852.2ef2638c.randy.dunlap@oracle.com>
On Fri, 2010-10-22 at 16:18 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle•com>
>
> nfs4state.c uses interfaces from ratelimit.h. It needs to include
> that header file to fix build errors:
>
> fs/nfs/nfs4state.c:1195: warning: type defaults to 'int' in declaration of 'DEFINE_RATELIMIT_STATE'
> fs/nfs/nfs4state.c:1195: warning: parameter names (without types) in function declaration
> fs/nfs/nfs4state.c:1195: error: invalid storage class for function 'DEFINE_RATELIMIT_STATE'
> fs/nfs/nfs4state.c:1195: error: implicit declaration of function '__ratelimit'
> fs/nfs/nfs4state.c:1195: error: '_rs' undeclared (first use in this function)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
> Cc: Trond Myklebust <Trond.Myklebust@netapp•com>
> Cc: linux-nfs@vger•kernel.org
> ---
> fs/nfs/nfs4state.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20101022.orig/fs/nfs/nfs4state.c
> +++ linux-next-20101022/fs/nfs/nfs4state.c
> @@ -46,6 +46,7 @@
> #include <linux/kthread.h>
> #include <linux/module.h>
> #include <linux/random.h>
> +#include <linux/ratelimit.h>
> #include <linux/workqueue.h>
> #include <linux/bitops.h>
>
That one is my fault. Sorry, and thanks Randy! I've applied the fix to
the linux-next branch...
Cheers
Trond
prev parent reply other threads:[~2010-10-23 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 4:23 linux-next: Tree for October 22 Stephen Rothwell
2010-10-22 23:12 ` linux-next: Tree for October 22 (acpi_video) Randy Dunlap
2010-10-22 23:18 ` [PATCH -next] ibm_rtl: fix printk format warning Randy Dunlap
2010-11-24 16:48 ` Matthew Garrett
2010-10-22 23:18 ` [PATCH -next] nfs: include ratelimit.h, fix nfs4state build error Randy Dunlap
2010-10-23 14:09 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287842947.3022.7.camel@heimdal.trondhjem.org \
--to=trond.myklebust@netapp$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox