From: Ian Campbell <Ian.Campbell@eu•citrix.com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Jeremy Fitzhardinge <jeremy@goop•org>,
Xen Devel <Xen-devel@lists•xensource.com>,
Stefano Stabellini <Stefano.Stabellini@eu•citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the xen tree
Date: Mon, 25 Oct 2010 09:38:26 +0100 [thread overview]
Message-ID: <1287995906.11851.14219.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <20101025133021.53649fd1.sfr@canb.auug.org.au>
On Mon, 2010-10-25 at 03:30 +0100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the xen tree, today's linux-next build (s86_64 allmodconfig)
> failed like this:
>
> arch/x86/xen/setup.c: In function 'xen_memory_setup':
> arch/x86/xen/setup.c:161: error: implicit declaration of function 'xen_initial_domain'
>
> Caused by commit 9e9a5fcb04e3af077d1be32710298b852210d93f ("xen: use host
> E820 map for dom0"). See Rule 1 from Documentation/SubmitChecklist.
>
> I have used the xen tree from next-20101021 for today (due to the complex
> conflict in Friday's tree).
Sorry about that, there was a missing #include which was hidden for me
by a change in the swiotlb-xen tree (d8e0420603cf "xen: define
BIOVEC_PHYS_MERGEABLE()", FWIW). We shouldn't be relying on indirect
includes in that way so:
8<-----
Subject: xen: include xen/xen.h for definition of xen_initial_domain()
CC arch/x86/xen/setup.o
arch/x86/xen/setup.c: In function 'xen_memory_setup':
arch/x86/xen/setup.c:161: error: implicit declaration of function 'xen_initial_domain'
Signed-off-by: Ian Campbell <ian.campbell@citrix•com>
--- arch/x86/xen/setup.c.orig 2010-10-25 09:31:42.000000000 +0100
+++ arch/x86/xen/setup.c 2010-10-25 09:31:49.000000000 +0100
@@ -18,6 +18,7 @@
#include <asm/xen/hypervisor.h>
#include <asm/xen/hypercall.h>
+#include <xen/xen.h>
#include <xen/page.h>
#include <xen/interface/callback.h>
#include <xen/interface/memory.h>
next prev parent reply other threads:[~2010-10-25 8:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 2:30 linux-next: build failure after merge of the xen tree Stephen Rothwell
2010-10-25 8:38 ` Ian Campbell [this message]
2010-10-25 23:57 ` Jeremy Fitzhardinge
-- strict thread matches above, loose matches on Subject: below --
2011-09-15 5:27 Stephen Rothwell
2011-09-15 9:10 ` Jeremy Fitzhardinge
2010-10-27 2:02 Stephen Rothwell
2010-07-28 4:18 Stephen Rothwell
2010-07-23 4:01 Stephen Rothwell
2010-07-23 4:48 ` Jeremy Fitzhardinge
2010-07-23 5:56 ` Jeremy Fitzhardinge
2010-07-23 6:05 ` Jeremy Fitzhardinge
2010-07-23 6:59 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287995906.11851.14219.camel@zakaz.uk.xensource.com \
--to=ian.campbell@eu$(echo .)citrix.com \
--cc=Stefano.Stabellini@eu$(echo .)citrix.com \
--cc=Xen-devel@lists$(echo .)xensource.com \
--cc=jeremy@goop$(echo .)org \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox