From: Trond Myklebust <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public•gmane.org>
To: Ingo Molnar <mingo-X9Un+BFzKDI@public•gmane.org>,
Charles Edward Lever
<Chuck.Lever-QHcLZuEGTsvQT0dZR+AlfA@public•gmane.org>
Cc: Zimny Lech
<napohybelskurwysynom2010-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public•gmane.org>,
linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public•gmane.org>
Subject: Re: linux-next: Tree for October 6
Date: Tue, 26 Oct 2010 08:32:13 -0400 [thread overview]
Message-ID: <1288096333.3123.9.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <20101026080822.GA10520-X9Un+BFzKDI@public.gmane.org>
On Tue, 2010-10-26 at 10:08 +0200, Ingo Molnar wrote:
> * Zimny Lech <napohybelskurwysynom2010-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org> wrote:
>
> > 2010/10/6 Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public•gmane.org>:
> > > Hi all,
> > >
> > > Changes since 20101005:
> >
> > It looka like a bug or a beetle or something like that
> >
> > /home/test/linux-2.6/fs/nfs/nfsroot.c: In function 'nfs_root_debug':
> > /home/test/linux-2.6/fs/nfs/nfsroot.c:110:2: error: 'nfs_debug'
> > undeclared (first use in this function)
> > /home/test/linux-2.6/fs/nfs/nfsroot.c:110:2: note: each undeclared
> > identifier is reported only once for each function it appears in
> > make[3]: *** [fs/nfs/nfsroot.o] Error 1
> > make[2]: *** [fs/nfs] Error 2
> > make[1]: *** [fs] Error 2
> > make: *** [sub-make] Error 2
>
> This build bug has now been pushed upstream and triggers rather easily. Trond?
>
> Thanks,
>
> Ingo
Grrr.... Chuck, I forwarded this report to you almost 3 weeks ago.
Anyhow, does the following fix the bug?
Cheers
Trond
----------------------------------------------------------------------------------------
NFS: Fix a compile issue in nfs_root
From: Trond Myklebust <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public•gmane.org>
Stephen Rothwell reports:
> /home/test/linux-2.6/fs/nfs/nfsroot.c: In function 'nfs_root_debug':
> /home/test/linux-2.6/fs/nfs/nfsroot.c:110:2: error: 'nfs_debug'
> undeclared (first use in this function)
> /home/test/linux-2.6/fs/nfs/nfsroot.c:110:2: note: each undeclared
> identifier is reported only once for each function it appears in
> make[3]: *** [fs/nfs/nfsroot.o] Error 1
> make[2]: *** [fs/nfs] Error 2
> make[1]: *** [fs] Error 2
> make: *** [sub-make] Error 2
Which is caused by commit 306a075362a288683f6346185f97dd0e06df19da
(NFS: Allow NFSROOT debugging messages to be enabled dynamically)
Fix is to disable this code when RPC_DEBUG is disabled.
Signed-off-by: Trond Myklebust <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public•gmane.org>
---
fs/nfs/nfsroot.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/nfs/nfsroot.c b/fs/nfs/nfsroot.c
index 460df36..903908a 100644
--- a/fs/nfs/nfsroot.c
+++ b/fs/nfs/nfsroot.c
@@ -101,6 +101,7 @@ static char nfs_export_path[NFS_MAXPATHLEN + 1] __initdata = "";
/* server:export path string passed to super.c */
static char nfs_root_device[NFS_MAXPATHLEN + 1] __initdata = "";
+#ifdef RPC_DEBUG
/*
* When the "nfsrootdebug" kernel command line option is specified,
* enable debugging messages for NFSROOT.
@@ -112,6 +113,7 @@ static int __init nfs_root_debug(char *__unused)
}
__setup("nfsrootdebug", nfs_root_debug);
+#endif
/*
* Parse NFS server and directory information passed on the kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-10-26 12:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 5:36 linux-next: Tree for October 6 Stephen Rothwell
2010-10-06 6:25 ` Zimny Lech
2010-10-06 6:48 ` Stephen Rothwell
2010-10-06 18:07 ` Zimny Lech
2010-10-06 18:12 ` Christoph Lameter
2010-10-06 18:15 ` Pekka Enberg
2010-10-06 18:20 ` Christoph Lameter
2010-10-06 19:23 ` Pekka Enberg
2010-10-06 20:09 ` Christoph Lameter
2010-10-06 18:16 ` Zimny Lech
2010-10-06 18:14 ` Zimny Lech
2010-10-06 18:22 ` Zimny Lech
2010-10-26 8:08 ` Ingo Molnar
[not found] ` <20101026080822.GA10520-X9Un+BFzKDI@public.gmane.org>
2010-10-26 12:32 ` Trond Myklebust [this message]
2010-10-26 12:41 ` Ingo Molnar
2010-10-26 12:57 ` Stephen Rothwell
[not found] ` <20101026124113.GA10872-X9Un+BFzKDI@public.gmane.org>
2010-10-26 17:52 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2009-10-06 5:52 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288096333.3123.9.camel@heimdal.trondhjem.org \
--to=trond.myklebust-hgovqubeegtqt0dzr+alfa@public$(echo .)gmane.org \
--cc=Chuck.Lever-QHcLZuEGTsvQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=mingo-X9Un+BFzKDI@public$(echo .)gmane.org \
--cc=napohybelskurwysynom2010-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public$(echo .)gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox