From: Steven Rostedt <rostedt@goodmis•org>
To: mat <castet.matthieu@free•fr>
Cc: linux-kernel@vger•kernel.org,
linux-security-module@vger•kernel.org,
linux-next@vger•kernel.org,
Arjan van de Ven <arjan@infradead•org>,
James Morris <jmorris@namei•org>,
Andrew Morton <akpm@linux-foundation•org>, Andi Kleen <ak@muc•de>,
Thomas Gleixner <tglx@linutronix•de>,
"H. Peter Anvin" <hpa@zytor•com>, Ingo Molnar <mingo@elte•hu>,
Rusty Russell <rusty@rustcorp•com.au>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Dave Jones <davej@redhat•com>,
Siarhei Liakh <sliakh.lkml@gmail•com>,
Kees Cook <kees.cook@canonical•com>,
Peter Zijlstra <a.p.zijlstra@chello•nl>
Subject: Re: [PATCH 3/3 V13] RO/NX protection for loadable kernel
Date: Tue, 30 Nov 2010 19:38:05 -0500 [thread overview]
Message-ID: <1291163885.4881.22.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20101130222025.3ccf5c00@mat-laptop>
On Tue, 2010-11-30 at 22:20 +0100, mat wrote:
> That's look fine for me.
>
> But I wonder why ftrace_arch_code_modify_prepare isn't called ?
>
> It is only called when we start/stop tracing ?
Correct. There's no reason to use it for the changing of mcount callers
to nops. For core kernel code, it happens before SMP is enabled. For
modules, it happens before the module code is executed. Except for what
Rusty stated with the module parameters, but if you are executing
complex code with that, you deserve what you get ;-)
The initial changes are made outside of stop machine. The code is not
being executed by anyone else.
-- Steve
prev parent reply other threads:[~2010-12-01 0:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 21:35 [PATCH 3/3 V13] RO/NX protection for loadable kernel matthieu castet
2010-11-25 3:41 ` Valdis.Kletnieks
2010-11-26 17:23 ` mat
2010-11-29 16:59 ` Valdis.Kletnieks
2010-12-08 22:19 ` Kees Cook
2010-12-10 23:18 ` mat
2010-12-11 0:27 ` Kees Cook
[not found] ` <20101211115735.21b616fe@mat-laptop>
2010-12-11 23:15 ` Kees Cook
2010-12-22 12:40 ` Ingo Molnar
2010-12-22 21:35 ` Valdis.Kletnieks
2010-12-22 21:57 ` Ingo Molnar
2010-12-22 22:02 ` Steven Rostedt
2010-12-23 8:49 ` Ingo Molnar
2010-12-23 15:01 ` Steven Rostedt
2010-12-24 1:43 ` Valdis.Kletnieks
2011-01-07 9:34 ` Xiaotian Feng
2011-01-07 13:04 ` Ingo Molnar
2011-01-08 11:24 ` matthieu castet
2011-01-10 23:49 ` Kees Cook
2011-01-11 22:42 ` matthieu castet
2011-01-20 20:32 ` matthieu castet
2011-01-21 2:35 ` Xiaotian Feng
2010-11-29 18:15 ` Steven Rostedt
2010-11-29 23:35 ` Rusty Russell
2010-11-30 14:46 ` Steven Rostedt
2010-12-01 13:36 ` Rusty Russell
2010-11-30 21:20 ` mat
2010-12-01 0:38 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291163885.4881.22.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis$(echo .)org \
--cc=a.p.zijlstra@chello$(echo .)nl \
--cc=ak@muc$(echo .)de \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arjan@infradead$(echo .)org \
--cc=castet.matthieu@free$(echo .)fr \
--cc=davej@redhat$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=jmorris@namei$(echo .)org \
--cc=kees.cook@canonical$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-security-module@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=rusty@rustcorp$(echo .)com.au \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=sliakh.lkml@gmail$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox