From: "John W. Linville" <linville@tuxdriver•com>
To: linux-wireless@vger•kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k•org>,
Larry Finger <Larry.Finger@lwfinger•net>,
George <george0505@realtek•com>,
linux-next@vger•kernel.org,
"John W. Linville" <linville@tuxdriver•com>
Subject: [PATCH] rtlwifi: usb parts should depend on CONFIG_USB
Date: Mon, 28 Feb 2011 14:48:20 -0500 [thread overview]
Message-ID: <1298922500-21632-1-git-send-email-linville@tuxdriver.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1102171354200.16788@ayla.of.borg>
ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_control_msg" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_submit_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_get_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_kill_anchored_urbs" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_put_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_free_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_anchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_alloc_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [sub-make] Error 2
The USB-part of rtlwifi should depend on CONFIG_USB.
Reported-by: Geert Uytterhoeven <geert@linux-m68k•org>
Signed-off-by: John W. Linville <linville@tuxdriver•com>
---
drivers/net/wireless/rtlwifi/Makefile | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/Makefile b/drivers/net/wireless/rtlwifi/Makefile
index 9192fd5..27355be 100644
--- a/drivers/net/wireless/rtlwifi/Makefile
+++ b/drivers/net/wireless/rtlwifi/Makefile
@@ -7,8 +7,7 @@ rtlwifi-objs := \
efuse.o \
ps.o \
rc.o \
- regd.o \
- usb.o
+ regd.o
rtl8192c_common-objs += \
@@ -16,6 +15,10 @@ ifeq ($(CONFIG_PCI),y)
rtlwifi-objs += pci.o
endif
+ifeq ($(CONFIG_USB),y)
+rtlwifi-objs += usb.o
+endif
+
obj-$(CONFIG_RTL8192C_COMMON) += rtl8192c/
obj-$(CONFIG_RTL8192CE) += rtl8192ce/
obj-$(CONFIG_RTL8192CU) += rtl8192cu/
--
1.7.4
next prev parent reply other threads:[~2011-02-28 20:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 12:56 [-next] ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! Geert Uytterhoeven
2011-02-28 19:48 ` John W. Linville [this message]
[not found] ` <1298922500-21632-1-git-send-email-linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2011-02-28 20:08 ` [PATCH] rtlwifi: usb parts should depend on CONFIG_USB Johannes Berg
[not found] ` <1298923731.10109.0.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2011-02-28 20:13 ` John W. Linville
[not found] ` <20110228201357.GF2515-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2011-02-28 21:16 ` Larry Finger
2011-02-28 21:21 ` Johannes Berg
[not found] ` <1298928111.12230.0.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2011-02-28 21:27 ` Larry Finger
2011-03-01 18:53 ` [PATCH v2] " John W. Linville
2011-03-01 19:54 ` Larry Finger
2011-02-28 21:01 ` [PATCH] " Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298922500-21632-1-git-send-email-linville@tuxdriver.com \
--to=linville@tuxdriver$(echo .)com \
--cc=Larry.Finger@lwfinger$(echo .)net \
--cc=geert@linux-m68k$(echo .)org \
--cc=george0505@realtek$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox