From: Sedat Dilek <sedat.dilek@googlemail•com>
Cc: Sedat Dilek <sedat.dilek@gmail•com>,
Alexander van Heukelum <heukelum@fastmail•fm>,
"H.J. Lu" <hjl.tools@gmail•com>, Len Brown <len.brown@intel•com>,
Pavel Machek <pavel@ucw•cz>, "Rafael J. Wysocki" <rjw@sisk•pl>,
Thomas Gleixner <tglx@linutronix•de>,
Ingo Molnar <mingo@redhat•com>, "H. Peter Anvin" <hpa@zytor•com>,
x86@kernel•org, linux-pm@lists•linux-foundation.org,
linux-kernel@vger•kernel.org, linux-next@vger•kernel.org
Subject: [PATCH] x86: Fix ACPI wakeup build failure
Date: Tue, 8 Mar 2011 22:39:24 +0100 [thread overview]
Message-ID: <1299620364-21644-1-git-send-email-sedat.dilek@gmail.com> (raw)
This fixes the following breakage in linux-next (next-20110308):
AS arch/x86/kernel/acpi/wakeup_rm.o
arch/x86/kernel/acpi/wakeup_rm.S: Assembler messages:
arch/x86/kernel/acpi/wakeup_rm.S:12: Error: .size expression with symbol `wakeup_code_start' does not evaluate to a constant
The issue was introduced by commit d1ee433539ea5963a8f946f3428b335d1c5fdb20:
"x86, trampoline: Use the unified trampoline setup for ACPI wakeup"
The problem was discovered while using Debian's binutils (2.21.0.20110302-1)
and experimenting with binutils from upstream.
Thanks Alexander and H.J. for the vital help.
CC: Alexander van Heukelum <heukelum@fastmail•fm>
CC: "H.J. Lu" <hjl.tools@gmail•com>
CC: Len Brown <len.brown@intel•com>
CC: Pavel Machek <pavel@ucw•cz>
CC: "Rafael J. Wysocki" <rjw@sisk•pl>
CC: Thomas Gleixner <tglx@linutronix•de>
CC: Ingo Molnar <mingo@redhat•com>
CC: "H. Peter Anvin" <hpa@zytor•com>
CC: x86@kernel•org
CC: linux-pm@lists•linux-foundation.org
CC: linux-kernel@vger•kernel.org
CC: linux-next@vger•kernel.org
Signed-off-by: Sedat Dilek <sedat.dilek@gmail•com>
---
arch/x86/kernel/acpi/wakeup_rm.S | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/acpi/wakeup_rm.S b/arch/x86/kernel/acpi/wakeup_rm.S
index 6ce81ee..63b8ab5 100644
--- a/arch/x86/kernel/acpi/wakeup_rm.S
+++ b/arch/x86/kernel/acpi/wakeup_rm.S
@@ -9,4 +9,4 @@
.globl acpi_wakeup_code
acpi_wakeup_code:
.incbin "arch/x86/kernel/acpi/realmode/wakeup.bin"
- .size wakeup_code_start, .-wakeup_code_start
+ .size acpi_wakeup_code, .-acpi_wakeup_code
--
1.7.4.1
next reply other threads:[~2011-03-08 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 21:39 Sedat Dilek [this message]
2011-03-08 22:32 ` [PATCH] x86: Fix ACPI wakeup build failure Alexander van Heukelum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299620364-21644-1-git-send-email-sedat.dilek@gmail.com \
--to=sedat.dilek@googlemail$(echo .)com \
--cc=heukelum@fastmail$(echo .)fm \
--cc=hjl.tools@gmail$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=len.brown@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-pm@lists$(echo .)linux-foundation.org \
--cc=mingo@redhat$(echo .)com \
--cc=pavel@ucw$(echo .)cz \
--cc=rjw@sisk$(echo .)pl \
--cc=sedat.dilek@gmail$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox