Subject: Re: linux-next: Tree for April 1 [BROKEN ubifs when CONFIG_DEBUG_SECTION_MISMATCH=y]

From: Artem Bityutskiy <[email-masked]>
Date: Fri, 01 Apr 2011 20:02:29 +0300

On Fri, 2011-04-01 at 18:10 +0200, Sedat Dilek wrote:
> On Fri, Apr 1, 2011 at 6:06 PM, Stephen Rothwell <[email-masked]> wrote:
> > Cc'ing Artem,
> >
> > On Fri, 1 Apr 2011 17:55:52 +0200 Sedat Dilek <[email-masked]> wrote:
> >>
> >> With CONFIG_DEBUG_SECTION_MISMATCH=y set, I see in my build.log:
> >> ...
> >> MODPOST 2742 modules
> >> ...
> >> ERROR: "empty_aops" [fs/ubifs/ubifs.ko] undefined!
> >> make[5]: *** [__modpost] Error 1
> >> make[4]: *** [modules] Error 2
> >> make[3]: *** [sub-make] Error 2
> >> make[2]: *** [all] Error 2
> >> make[2]: Leaving directory
> >> `/home/sd/src/linux-2.6/linux-2.6.39-rc1/debian/build/build_i386_none_686-iniza'
> >>
> >> - Sedat -
> >>
> >
> >
> > --
> > Cheers,
> > Stephen Rothwell                    [email-masked]
> > http://www.canb.auug.org.au/~sfr/
> >
> 
> Speculative patch (untested).
> 
> - Sedat -
> 
> $ diff -uprN fs/ubifs/xattr.c.orig fs/ubifs/xattr.c
> --- fs/ubifs/xattr.c.orig       2011-04-01 15:56:08.471082117 +0200
> +++ fs/ubifs/xattr.c    2011-04-01 18:08:27.355276827 +0200
> @@ -81,6 +81,7 @@ enum {
> 
>  static const struct inode_operations none_inode_operations;
>  static const struct file_operations none_file_operations;
> +static const struct address_space_operations empty_aops;
> 
>  /**
>   * create_xattr - create an extended attribute.

ubifs doess not have 'empty_aops' symbol and does not use such symbol. I
do not understand how you got that build issue, but this must be
something to do with your local setup.

Also:

[dedekind@eru linux-next (master)]$ grep -r 'empty_aops' *
fs/nilfs2/page.c:       static const struct address_space_operations empty_aops;
fs/nilfs2/page.c:       mapping->a_ops = &empty_aops;
fs/inode.c:     static const struct address_space_operations empty_aops;
fs/inode.c:     mapping->a_ops = &empty_aops;

in the current linux-next.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)