public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail•com>
To: Randy Dunlap <randy.dunlap@oracle•com>,
	David Miller <davem@davemloft•net>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
	netdev <netdev@vger•kernel.org>,
	linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: Tree for April 29 (bpf_jit)
Date: Fri, 29 Apr 2011 19:19:18 +0200	[thread overview]
Message-ID: <1304097558.2686.6.camel@edumazet-laptop> (raw)
In-Reply-To: <20110429092632.26ff1e53.randy.dunlap@oracle.com>

Le vendredi 29 avril 2011 à 09:26 -0700, Randy Dunlap a écrit :
> On Fri, 29 Apr 2011 13:19:40 +1000 Stephen Rothwell wrote:
> 
> > Hi all,
> > 
> > Changes since 20110428:
> 
> 
> when CONFIG_MODULES is not enabled:
> 
> bpf_jit_comp.c:(.text+0x43cc2): undefined reference to `module_free'
> (.text+0x4521a): undefined reference to `module_alloc'
> (.text+0x453af): undefined reference to `module_free'
> 
> 

Oh well, I guess we can add one 'depends on MODULES' like we do for
KPROBES (it also uses module_alloc())

Not sure many people build a !CONFIG_MODULES kernel these days...

Thanks Randy !

[PATCH net-next-2.6] bpf: depends on MODULES

module_alloc() and module_free() are available only if CONFIG_MODULES=y

Reported-by: Randy Dunlap <randy.dunlap@oracle•com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail•com>
---
 net/Kconfig |    1 +
 1 files changed, 1 insertion(+)

diff --git a/net/Kconfig b/net/Kconfig
index 745fb02..878151c 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -238,6 +238,7 @@ config HAVE_BPF_JIT
 config BPF_JIT
 	bool "enable BPF Just In Time compiler"
 	depends on HAVE_BPF_JIT
+	depends on MODULES
 	---help---
 	  Berkeley Packet Filter filtering capabilities are normally handled
 	  by an interpreter. This option allows kernel to generate a native

  reply	other threads:[~2011-04-29 17:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-29  3:19 linux-next: Tree for April 29 Stephen Rothwell
2011-04-29 16:10 ` linux-next: Tree for April 29 (uml build issue) Randy Dunlap
2011-04-29 16:21 ` linux-next: Tree for April 29 (gpu/drm) Randy Dunlap
2011-04-29 16:26 ` linux-next: Tree for April 29 (bpf_jit) Randy Dunlap
2011-04-29 17:19   ` Eric Dumazet [this message]
2011-04-29 17:21     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304097558.2686.6.camel@edumazet-laptop \
    --to=eric.dumazet@gmail$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=randy.dunlap@oracle$(echo .)com \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox