From: Joe Perches <joe@perches•com>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
netdev <netdev@vger•kernel.org>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
davem@davemloft•net
Subject: Re: linux-next: Tree for May 24 (ratelimits, CONFIG_PRINTK not enabled)
Date: Tue, 24 May 2011 11:49:48 -0700 [thread overview]
Message-ID: <1306262988.2298.49.camel@Joe-Laptop> (raw)
In-Reply-To: <20110524113328.e3d5867b.randy.dunlap@oracle.com>
On Tue, 2011-05-24 at 11:33 -0700, Randy Dunlap wrote:
> On Tue, 24 May 2011 14:02:12 +1000 Stephen Rothwell wrote:
> > Hi all,
> > Changes since 20110523:
> when CONFIG_PRINTK is not enabled:
> net/core/filter.c:353: warning: type defaults to 'int' in declaration of 'DEFINE_RATELIMIT_STATE'
> net/core/filter.c:353: warning: parameter names (without types) in function declaration
> net/core/filter.c:353: error: invalid storage class for function 'DEFINE_RATELIMIT_STATE'
> net/core/filter.c:353: error: implicit declaration of function '__ratelimit'
> net/core/filter.c:353: error: '_rs' undeclared (first use in this function)
Thanks for the report Randy.
I wonder if it's better to new create sections for
!CONFIG_PRINTK in bug.h. That might make the image
a bit smaller when !CONFIG_PRINTK too.
> Adding <linux/ratelimit.h> to <asm-generic/bug.h> causes other problems:
Yup, that's not a good solution.
next prev parent reply other threads:[~2011-05-24 18:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 4:02 linux-next: Tree for May 24 Stephen Rothwell
2011-05-24 18:33 ` linux-next: Tree for May 24 (ratelimits, CONFIG_PRINTK not enabled) Randy Dunlap
2011-05-24 18:49 ` Joe Perches [this message]
2011-05-24 19:32 ` David Miller
2011-05-24 19:49 ` Joe Perches
2011-05-24 19:53 ` David Miller
2011-05-24 20:11 ` Randy Dunlap
2011-05-24 20:14 ` David Miller
2011-05-24 18:47 ` [PATCH -next] kmsg_dump.h: fix build when CONFIG_PRINTK is disabled Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306262988.2298.49.camel@Joe-Laptop \
--to=joe@perches$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox