public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi•org>
To: Randy Dunlap <rdunlap@xenotime•net>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
	scsi <linux-scsi@vger•kernel.org>,
	linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
	target-devel@vger•kernel.org
Subject: Re: linux-next: Tree for July 27 (iscsi_target) [resend/lost]
Date: Wed, 27 Jul 2011 13:11:07 -0700	[thread overview]
Message-ID: <1311797467.6931.20.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20110727104716.dda819dc.rdunlap@xenotime.net>

On Wed, 2011-07-27 at 10:47 -0700, Randy Dunlap wrote:
> On Wed, 27 Jul 2011 14:11:51 +1000 Stephen Rothwell wrote:
> 
> > Hi all,
> 
> iscsi_target_login.c:(.text+0x13d3f5): undefined reference to `iscsit_thread_get_cpumask'
> iscsi_target_login.c:(.text+0x13d594): undefined reference to `iscsit_thread_get_cpumask'
> 
> kernel config file is attached.
> 
> 

Hi Randy,

Addressing this config with the following patch:

commit b7123c56c95dcf3cc5fbdfeaceb416699d378e08
Author: Nicholas Bellinger <nab@linux-iscsi•org>
Date:   Wed Jul 27 20:13:22 2011 +0000

    iscsi-target: Fix CONFIG_SMP=n and CONFIG_MODULES=n build failure
    
    This patch fixes the following CONFIG_SMP=n and CONFIG_MODULES=n build
    failure, because iscsit_thread_get_cpumask() is defined as a macro in
    iscsi_target.c, but needed by iscsi_target_login.c
    
    drivers/built-in.o: In function `iscsi_post_login_handler':
    iscsi_target_login.c:(.text+0x13a315): undefined reference to `iscsit_thread_get_cpumask'
    iscsi_target_login.c:(.text+0x13a4b4): undefined reference to `iscsit_thread_get_cpumask'
    make: *** [.tmp_vmlinux1] Error 1
    
    Reported-by: Randy Dunlap <rdunlap@xenotime•net>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi•org>

diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index 5ae3017..8f92d0d 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -3468,7 +3468,12 @@ static inline void iscsit_thread_check_cpumask(
 }
 
 #else
-#define iscsit_thread_get_cpumask(X) ({})
+
+void iscsit_thread_get_cpumask(struct iscsi_conn *conn)
+{
+       return;
+}
+
 #define iscsit_thread_check_cpumask(X, Y, Z) ({})
 #endif /* CONFIG_SMP */
 

> Shouldn't MAINTAINERS list target-devel@vger•kernel.org ?
> 

Adding this as well now..

Thanks!

--nab


      parent reply	other threads:[~2011-07-27 20:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-27  4:11 linux-next: Tree for July 27 Stephen Rothwell
2011-07-27 16:27 ` [patch] Re: linux-next: Tree for July 27 (misc/pti) Randy Dunlap
2011-07-27 18:54   ` J Freyensee
2011-07-27 16:41 ` linux-next: Tree for July 27 (watchdog/hpwdt) Randy Dunlap
2011-07-27 19:39   ` Wim Van Sebroeck
2011-07-27 17:11 ` [PATCH -next] firmware: fix google/gsmi.c build warning Randy Dunlap
2011-07-27 19:49   ` Mike Waychison
2011-07-27 18:42 ` [PATCH -next] tpm_tis: fix build when ACPI is not enabled Randy Dunlap
2011-08-03 18:56   ` Ingo Molnar
2011-08-04  1:34     ` James Morris
     [not found] ` <20110727104716.dda819dc.rdunlap@xenotime.net>
2011-07-27 20:11   ` Nicholas A. Bellinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311797467.6931.20.camel@haakon2.linux-iscsi.org \
    --to=nab@linux-iscsi$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=linux-scsi@vger$(echo .)kernel.org \
    --cc=rdunlap@xenotime$(echo .)net \
    --cc=sfr@canb$(echo .)auug.org.au \
    --cc=target-devel@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox