From: "Nicholas A. Bellinger" <nab@linux-iscsi•org>
To: Randy Dunlap <rdunlap@xenotime•net>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
scsi <linux-scsi@vger•kernel.org>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
target-devel@vger•kernel.org
Subject: Re: [PATCH -next] target: iscsi_target depends on NET
Date: Thu, 28 Jul 2011 13:10:13 -0700 [thread overview]
Message-ID: <1311883813.6931.196.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20110728094819.22e19fe9.rdunlap@xenotime.net>
On Thu, 2011-07-28 at 09:48 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime•net>
>
> iscsi target code uses lots on network interface functions, so it
> should depend on NET. Fixes many build errors when NET is not enabled:
>
> ERROR: "kernel_sendmsg" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "in_aton" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "sock_release" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "kernel_listen" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "kernel_setsockopt" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "kernel_recvmsg" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "kernel_accept" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "sock_create" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "kernel_bind" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "in6_pton" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime•net>
> ---
> drivers/target/iscsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20110728.orig/drivers/target/iscsi/Kconfig
> +++ linux-next-20110728/drivers/target/iscsi/Kconfig
> @@ -1,5 +1,6 @@
> config ISCSI_TARGET
> tristate "Linux-iSCSI.org iSCSI Target Mode Stack"
> + depends on NET
> select CRYPTO
> select CRYPTO_CRC32C
> select CRYPTO_CRC32C_INTEL if X86
Committed as d52a10d00 and pushed into target-pending.git/for-next.
Thanks Randy!
--nab
prev parent reply other threads:[~2011-07-28 20:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 3:57 linux-next: Tree for July 28 Stephen Rothwell
[not found] ` <20110728094819.22e19fe9.rdunlap@xenotime.net>
2011-07-28 20:10 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311883813.6931.196.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=rdunlap@xenotime$(echo .)net \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=target-devel@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox