From: Rajendra Nayak <rnayak@ti•com>
To: sfr@canb•auug.org.au, broonie@opensource•wolfsonmicro.com,
lrg@slimlogic•co.uk
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
heiko@sntech•de, Rajendra Nayak <rnayak@ti•com>
Subject: [PATCH] regulator: Fix compile break due to missing arguments to regulator_register
Date: Thu, 24 Nov 2011 12:57:17 +0530 [thread overview]
Message-ID: <1322119637-32634-1-git-send-email-rnayak@ti.com> (raw)
The commit 2c043bcbf287 ("regulator: pass additional of_node to
regulator_register()") caused a compile break because it missed
updating the regulator_register() call in gpio-regulator.c with
the additional parameter (NULL).
The compile break as reported by Stephen Rothwell with the
x86_64 allmodconfig looked like this
drivers/regulator/gpio-regulator.c: In function 'gpio_regulator_probe':
drivers/regulator/gpio-regulator.c:287:8: error: too few arguments to function 'regulator_register'
include/linux/regulator/driver.h:215:23: note: declared here
Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
Signed-off-by: Rajendra Nayak <rnayak@ti•com>
---
drivers/regulator/gpio-regulator.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index f0acf52..42e1cb1 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -284,7 +284,7 @@ static int __devinit gpio_regulator_probe(struct platform_device *pdev)
drvdata->state = state;
drvdata->dev = regulator_register(&drvdata->desc, &pdev->dev,
- config->init_data, drvdata);
+ config->init_data, drvdata, NULL);
if (IS_ERR(drvdata->dev)) {
ret = PTR_ERR(drvdata->dev);
dev_err(&pdev->dev, "Failed to register regulator: %d\n", ret);
--
1.7.1
next reply other threads:[~2011-11-24 7:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 7:27 Rajendra Nayak [this message]
2011-11-24 10:51 ` [PATCH] regulator: Fix compile break due to missing arguments to regulator_register Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322119637-32634-1-git-send-email-rnayak@ti.com \
--to=rnayak@ti$(echo .)com \
--cc=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=heiko@sntech$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=lrg@slimlogic$(echo .)co.uk \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox