From: <Tudor.Ambarus@microchip•com>
To: <sfr@canb•auug.org.au>
Cc: <vigneshr@ti•com>, <linux-next@vger•kernel.org>,
<linux-kernel@vger•kernel.org>,
<sergei.shtylyov@cogentembedded•com>
Subject: Re: linux-next: Fixes tag needs some work in the spi-nor tree
Date: Fri, 29 May 2020 07:31:47 +0000 [thread overview]
Message-ID: <132770930.czcBmXCZeL@192.168.0.120> (raw)
In-Reply-To: <20200529070647.5946fe06@canb.auug.org.au>
On Friday, May 29, 2020 12:06:47 AM EEST Stephen Rothwell wrote:
> Hi all,
Hi, Stephen,
>
> In commit
>
> 5587fa489747 ("mtd: spi-nor: spansion: fix writes on S25FS512S")
>
> Fixes tag
>
> Fixes: dfd2b74530e ("mtd: spi-nor: add Spansion S25FS512S ID")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
Right. Maybe it is worth to add this kind of check in checkpatch.pl. One can
generate the Fixes tag by adding an alias in .gitconfig:
[alias]
fixes = show --format='Fixes: %h (\"%s\")' -s
And generate the Fixes tag with "git fixes sha1"
Cheers,
ta
next prev parent reply other threads:[~2020-05-29 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 21:06 linux-next: Fixes tag needs some work in the spi-nor tree Stephen Rothwell
2020-05-29 7:31 ` Tudor.Ambarus [this message]
2020-05-29 9:48 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2020-04-28 22:10 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=132770930.czcBmXCZeL@192.168.0.120 \
--to=tudor.ambarus@microchip$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=vigneshr@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox