From: "Myklebust, Trond" <Trond.Myklebust@netapp•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: "linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"Adamson, Dros" <Weston.Adamson@netapp•com>
Subject: Re: linux-next: build failure after merge of the final tree (nfs tree related)
Date: Tue, 20 Mar 2012 13:25:29 +0000 [thread overview]
Message-ID: <1332249929.2963.4.camel@lade.trondhjem.org> (raw)
In-Reply-To: <20120320192952.ed82031eec8a49cf7da40a8e@canb.auug.org.au>
On Tue, 2012-03-20 at 19:29 +1100, Stephen Rothwell wrote:
> Hi Trond,
>
> [This was previously reported as a warning ... but sparc uses -Werr in
> more places]
>
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> failed like this:
>
> In file included from arch/sparc/kernel/sys_sparc32.c:24:0:
> include/linux/nfs_fs.h: In function 'nfs_display_fhandle_hash':
> include/linux/nfs_fs.h:416:1: error: no return statement in function returning non-void [-Werror=return-type]
>
> Caused by commit d8e0539ebdff ("NFS: add filehandle crc for debug display").
>
> I added the following patch for today:
>
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Tue, 20 Mar 2012 19:26:42 +1100
> Subject: [PATCH] nfs: non void functions must return a value
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
> include/linux/nfs_fs.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/nfs_fs.h b/include/linux/nfs_fs.h
> index 8f27c2e..69ec9cb 100644
> --- a/include/linux/nfs_fs.h
> +++ b/include/linux/nfs_fs.h
> @@ -413,6 +413,7 @@ extern void _nfs_display_fhandle(const struct nfs_fh *fh, const char *caption);
> #else
> static inline u32 nfs_display_fhandle_hash(const struct nfs_fh *fh)
> {
> + return 0;
> }
> static inline void nfs_display_fhandle(const struct nfs_fh *fh,
> const char *caption)
Thanks Stephen! I've applied the above patch to my tree.
Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp•com
www.netapp.com
next prev parent reply other threads:[~2012-03-20 13:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 8:29 linux-next: build failure after merge of the final tree (nfs tree related) Stephen Rothwell
2012-03-20 13:25 ` Myklebust, Trond [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-11-18 2:20 Stephen Rothwell
2012-01-23 2:59 Stephen Rothwell
2012-01-23 18:10 ` Trond Myklebust
2012-01-24 8:38 ` Stanislav Kinsbursky
2010-09-30 3:58 Stephen Rothwell
2010-09-30 13:08 ` Bryan Schumaker
2010-08-04 4:54 Stephen Rothwell
2010-08-04 12:58 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332249929.2963.4.camel@lade.trondhjem.org \
--to=trond.myklebust@netapp$(echo .)com \
--cc=Weston.Adamson@netapp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox