Subject: Re: Commit "arm: convert drivers to scsi proc_ops" breaks linux-next

From: James Bottomley <[email-masked]>
Date: Tue, 27 Mar 2012 08:51:25 +0000

On Mon, 2012-03-26 at 22:51 -0400, Paul Gortmaker wrote:
> Hi Alexey,
> 
> This error showed up in linux-next today:
> 
>  CC      drivers/scsi/arm/powertec.o
> drivers/scsi/arm/powertec.c: In function 'powertecscsi_proc_show':
> drivers/scsi/arm/powertec.c:199: error: dereferencing pointer to incomplete type
> drivers/scsi/arm/powertec.c:202: error: implicit declaration of function 'seq_printf'
> drivers/scsi/arm/powertec.c: In function 'powertecscsi_proc_open':
> drivers/scsi/arm/powertec.c:214: error: implicit declaration of function 'single_open'
> drivers/scsi/arm/powertec.c: At top level:
> drivers/scsi/arm/powertec.c:250: error: 'seq_read' undeclared here (not in a function)
> drivers/scsi/arm/powertec.c:251: error: 'seq_lseek' undeclared here (not in a function)
> drivers/scsi/arm/powertec.c:252: error: 'single_release' undeclared here (not in a function)
> 
> and a bisect leads to this:
> 
> --------------
> commit bb6c20445c1bdd1c49ac5e76801211116694e3b9
> Author: Alexey Dobriyan <[email-masked]>
> Date:   Wed Feb 22 22:46:23 2012 +0300
> 
>     [SCSI] arm: convert drivers to scsi proc_ops
>     
>     Signed-off-by: Alexey Dobriyan <[email-masked]>
>     Signed-off-by: James Bottomley <[email-masked]>
> --------------

Could you dig a little deeper on this one?  seq_printf is defined in
include/linux/seq_file.h which is included by this commit.  I can't see
why the function prototype should end up undefined.

Could the include guards for this file be getting set erroneously
somehow?

James