From: "Nicholas A. Bellinger" <nab@linux-iscsi•org>
To: Randy Dunlap <rdunlap@xenotime•net>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
linux-usb@vger•kernel.org, target-devel@vger•kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix•de>,
Greg KH <gregkh@linuxfoundation•org>
Subject: Re: linux-next: Tree for Apr 20 (usb & target)
Date: Sat, 21 Apr 2012 02:07:43 -0700 [thread overview]
Message-ID: <1334999263.30707.129.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <4F91D9D9.6020609@xenotime.net>
On Fri, 2012-04-20 at 14:49 -0700, Randy Dunlap wrote:
> On 04/19/2012 10:51 PM, Stephen Rothwell wrote:
>
> > Hi all,
> >
> > Changes since 20120419:
>
>
Hi Randy,
> CONFIG_MODULES is not enabled.
> CONFIG_TCM_USB_GADGET=y
> CONFIG_USB_GADGET=y
>
> drivers/usb/built-in.o: In function `usb_descriptor_fillbuf':
> (.text+0x53bb): multiple definition of `usb_descriptor_fillbuf'
> drivers/target/built-in.o:(.text+0x1e605): first defined here
> drivers/usb/built-in.o: In function `usb_string_ids_n':
> (.text+0x4f1a): multiple definition of `usb_string_ids_n'
> drivers/target/built-in.o:(.text+0x1f1ed): first defined here
> drivers/usb/built-in.o: In function `usb_interface_id':
> (.text+0x4ea8): multiple definition of `usb_interface_id'
> drivers/target/built-in.o:(.text+0x1f0bc): first defined here
> drivers/usb/built-in.o: In function `usb_string_id':
> (.text+0x4ecc): multiple definition of `usb_string_id'
> drivers/target/built-in.o:(.text+0x1f19f): first defined here
> drivers/usb/built-in.o: In function `usb_string_ids_tab':
> (.text+0x4ee8): multiple definition of `usb_string_ids_tab'
> drivers/target/built-in.o:(.text+0x1f1bb): first defined here
> drivers/usb/built-in.o: In function `usb_copy_descriptors':
> (.text+0x5a01): multiple definition of `usb_copy_descriptors'
> drivers/target/built-in.o:(.text+0x1ec48): first defined here
> drivers/usb/built-in.o: In function `usb_composite_unregister':
> (.text+0x4fe2): multiple definition of `usb_composite_unregister'
> drivers/target/built-in.o:(.text+0x1f2b5): first defined here
> drivers/usb/built-in.o: In function `config_ep_by_speed':
> (.text+0x4bd7): multiple definition of `config_ep_by_speed'
> drivers/target/built-in.o:(.text+0x1ecca): first defined here
> drivers/usb/built-in.o: In function `usb_gadget_get_string':
> (.text+0x5094): multiple definition of `usb_gadget_get_string'
> drivers/target/built-in.o:(.text+0x1dd85): first defined here
> drivers/usb/built-in.o: In function `usb_add_function':
> (.text+0x4cfc): multiple definition of `usb_add_function'
> drivers/target/built-in.o:(.text+0x1ee6c): first defined here
> drivers/usb/built-in.o: In function `usb_composite_probe':
> (.text+0x4f4a): multiple definition of `usb_composite_probe'
> drivers/target/built-in.o:(.text+0x1f21d): first defined here
> drivers/usb/built-in.o: In function `usb_composite_setup_continue':
> (.text+0x4ffd): multiple definition of `usb_composite_setup_continue'
> drivers/target/built-in.o:(.text+0x1f369): first defined here
> drivers/usb/built-in.o: In function `usb_gadget_config_buf':
> (.text+0x59ad): multiple definition of `usb_gadget_config_buf'
> drivers/target/built-in.o:(.text+0x1ebf4): first defined here
> drivers/usb/built-in.o: In function `usb_ep_autoconfig':
> (.text+0x5bba): multiple definition of `usb_ep_autoconfig'
> drivers/target/built-in.o:(.text+0x1e358): first defined here
> drivers/usb/built-in.o: In function `usb_function_activate':
> (.text+0x4e29): multiple definition of `usb_function_activate'
> drivers/target/built-in.o:(.text+0x1f03b): first defined here
> drivers/usb/built-in.o: In function `usb_ep_autoconfig_reset':
> (.text+0x5bc7): multiple definition of `usb_ep_autoconfig_reset'
> drivers/target/built-in.o:(.text+0x1e365): first defined here
> drivers/usb/built-in.o: In function `usb_add_config':
> (.text+0x5e6a): multiple definition of `usb_add_config'
> drivers/target/built-in.o:(.text+0x1f0e0): first defined here
> drivers/usb/built-in.o: In function `usb_ep_autoconfig_ss':
> (.text+0x5a83): multiple definition of `usb_ep_autoconfig_ss'
> drivers/target/built-in.o:(.text+0x1e0ab): first defined here
> drivers/usb/built-in.o: In function `usb_function_deactivate':
> (.text+0x4dc2): multiple definition of `usb_function_deactivate'
> drivers/target/built-in.o:(.text+0x1efd4): first defined here
>
>
Mmmm, It looks like the source file include usage in target/usb-gadget.c
might be causing some problems here:
#include "usbstring.c"
#include "epautoconf.c"
#include "config.c"
#include "composite.c"
Sebastian + Greg-KH (Cc'ed), any ideas why this is the case here..?
Thanks,
--nab
next prev parent reply other threads:[~2012-04-21 9:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 5:51 linux-next: Tree for Apr 20 Stephen Rothwell
2012-04-20 21:49 ` linux-next: Tree for Apr 20 (usb & target) Randy Dunlap
2012-04-21 9:07 ` Nicholas A. Bellinger [this message]
2012-04-21 15:34 ` Greg KH
2012-04-22 19:01 ` Sebastian Andrzej Siewior
2012-05-04 3:34 ` Nicholas A. Bellinger
2012-05-04 9:41 ` Felipe Balbi
2012-05-04 16:56 ` Nicholas A. Bellinger
2012-05-04 22:15 ` Greg KH
2012-04-23 8:56 ` Felipe Balbi
2012-04-20 22:00 ` linux-next: Tree for Apr 20 (kvm) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334999263.30707.129.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi$(echo .)org \
--cc=bigeasy@linutronix$(echo .)de \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=rdunlap@xenotime$(echo .)net \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=target-devel@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox