From: "Myklebust, Trond" <Trond.Myklebust@netapp•com>
To: Paul Gortmaker <paul.gortmaker@windriver•com>
Cc: Randy Dunlap <rdunlap@xenotime•net>,
Stephen Rothwell <sfr@canb•auug.org.au>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
LKML <linux-kernel@vger•kernel.org>,
Al Viro <viro@zeniv•linux.org.uk>
Subject: Re: linux-next: Tree for May 10 (fs/inode.c)
Date: Tue, 15 May 2012 00:49:01 +0000 [thread overview]
Message-ID: <1337042961.2522.53.camel@lade.trondhjem.org> (raw)
In-Reply-To: <CAP=VYLrAjGjCHDhxrEypaKcqK1Yx7_XY_TZofsf5V9x7GCGr7g@mail.gmail.com>
On Thu, 2012-05-10 at 21:36 -0400, Paul Gortmaker wrote:
> On Thu, May 10, 2012 at 5:23 PM, Randy Dunlap <rdunlap@xenotime•net> wrote:
> > On 05/10/2012 02:26 AM, Stephen Rothwell wrote:
> >
> >> Hi all,
> >>
> >> Changes since 20120508:
> >
> >
> > when CONFIG_BLOCK is not set:
> >
> > fs/inode.c:1777:6: error: redefinition of 'inode_dio_wait'
> > include/linux/fs.h:2476:20: note: previous definition of 'inode_dio_wait'
> > was here
>
> Also seen on some arm builds:
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/6291357/
> http://kisskb.ellerman.id.au/kisskb/buildresult/6291378/
>
> 5eff3957ce8d14c2a254844743dfb84e19e7c2ae is the first bad commit
> commit 5eff3957ce8d14c2a254844743dfb84e19e7c2ae
> Author: Trond Myklebust <Trond.Myklebust@netapp•com>
> Date: Mon May 7 10:44:29 2012 -0400
>
> NFS: Ensure that setattr and getattr wait for O_DIRECT write completion
>
> Use the same mechanism as the block devices are using, but move the
> helper functions from fs/direct-io.c into fs/inode.c to remove the
> dependency on CONFIG_BLOCK.
>
> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp•com>
> Cc: Christoph Hellwig <hch@infradead•org>
> Cc: Al Viro <viro@zeniv•linux.org.uk>
> Cc: Fred Isaman <iisaman@netapp•com>
>
> :040000 040000 ae33e2ffd172e4d7e2ad6ed219de32de936548cc
> ef2df66b34559dbc0782add108e24a6ef6e4e2ca M fs
> bisect run success
>
> P.
Sorry about being so late with this. The changes to include/linux/fs.h
had not been committed in the original branch. Today's linux-next should
have that fixed...
Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp•com
www.netapp.com
next prev parent reply other threads:[~2012-05-15 0:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 9:26 linux-next: Tree for May 10 Stephen Rothwell
2012-05-10 21:23 ` linux-next: Tree for May 10 (fs/inode.c) Randy Dunlap
2012-05-11 1:36 ` Paul Gortmaker
2012-05-15 0:49 ` Myklebust, Trond [this message]
2012-05-10 21:40 ` linux-next: Tree for May 10 (net/phy) Randy Dunlap
2012-05-11 2:36 ` Paul Gortmaker
2012-05-11 2:43 ` David Miller
2012-05-11 15:47 ` [PATCH] net: of/phy: fix build error when phylib is built as a module Bjørn Mork
2012-05-11 17:58 ` David Daney
2012-05-11 22:03 ` David Miller
2012-05-11 21:24 ` David Miller
2012-05-11 23:50 ` Randy Dunlap
2012-05-11 16:14 ` linux-next: Tree for May 10 (net/phy) David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337042961.2522.53.camel@lade.trondhjem.org \
--to=trond.myklebust@netapp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=rdunlap@xenotime$(echo .)net \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox