From: "Myklebust, Trond" <Trond.Myklebust@netapp•com>
To: Mark Salter <msalter@redhat•com>, Fengguang Wu <fengguang.wu@intel•com>
Cc: linux-next <linux-next@vger•kernel.org>,
"linux-nfs@vger•kernel.org" <linux-nfs@vger•kernel.org>
Subject: Re: nfs root problem in linux-next
Date: Fri, 29 Jun 2012 13:55:49 +0000 [thread overview]
Message-ID: <1340978148.2498.6.camel@lade.trondhjem.org> (raw)
In-Reply-To: <1340680664.20557.38.camel@deneb.redhat.com>
On Mon, 2012-06-25 at 23:17 -0400, Mark Salter wrote:
> On Mon, 2012-06-25 at 23:14 +0000, Myklebust, Trond wrote:
> > On Mon, 2012-06-25 at 16:26 -0400, Mark Salter wrote:
> > > As of Friday's linux-next I've been unable to successfully boot using an
> > > nfs root with a c6x board. I bisected it to this patch:
> > >
> > > commit cc3b296fd9a01c9e654bcb9373af70dd6e32fb24
> > > Author: Trond Myklebust <Trond.Myklebust@netapp•com>
> > > Date: Thu Jun 21 14:53:10 2012 -0400
> > >
> > > SUNRPC: Clean up xdr_read_pages and xdr_enter_page
> > >
> > > I placed "good-boot" and "bad-boot" packet capture files at:
> > >
> > > http://people.redhat.com/~msalter/linux-next/
> > >
> > > The only difference in the kernels used is the above patch. The
> > > bad-boot mounted the nfs root but was unable to find the init
> > > file which caused a panic. The nfsroot= parameter uses v3,tcp
> > > flags and the server side is running rhel6.
> > >
> > > I'm not at all familiar with the nfs code, but can help with
> > > testing or providing any addtional info needed.
> >
> > Hi Mark,
> >
> > So you are saying that reverting that patch alone suffices to fix the
> > problem that you are seeing?
>
> Yes. If I check out a tree at commit cc3b296fd9a, the resulting kernel
> does not boot (it panics that it cannot find init). If I check out a
> tree at cc3b296fd9a~1, it boots the nfs root successfully.
>
> ...
> > I'll have a look to see if I can find out what is the problem. The only
> > significant change that patch should be introducing would be the use of
> > xdr_stream_pos().
>
> Okay. I am happy to help with any testing if needed to help characterize
> the problem better.
Hi Mark and Fengguang,
I believe that I've found the bug that was being triggered in the above
patch. It was a mistake in the earlier patch "SUNRPC: Don't decode
beyond the end of the RPC reply message", which was failing to correctly
initialise the xdr->nwords field.
I've now fixed it and updated the linux-next branch.
Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp•com
www.netapp.com
next prev parent reply other threads:[~2012-06-29 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 20:26 nfs root problem in linux-next Mark Salter
[not found] ` <1340656006.20557.30.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2012-06-25 23:14 ` Myklebust, Trond
[not found] ` <1340666049.4362.9.camel-SyLVLa/KEI9HwK5hSS5vWB2eb7JE58TQ@public.gmane.org>
2012-06-26 3:17 ` Mark Salter
2012-06-29 13:55 ` Myklebust, Trond [this message]
2012-06-29 14:48 ` Mark Salter
2012-06-29 14:53 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340978148.2498.6.camel@lade.trondhjem.org \
--to=trond.myklebust@netapp$(echo .)com \
--cc=fengguang.wu@intel$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=msalter@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox