From: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
To: linux-next@vger•kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols•net>
Subject: [PATCH] tools/perf: remove yet another strtoull()
Date: Wed, 8 Aug 2012 19:37:26 +0300 [thread overview]
Message-ID: <1344443846-5594-1-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20120808161849.GC2210@infradead.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols•net>
---
tools/perf/util/symbol.c | 24 ++----------------------
1 file changed, 2 insertions(+), 22 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 8b63b67..26e695c 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -2825,35 +2825,15 @@ int machines__create_kernel_maps(struct rb_root *machines, pid_t pid)
return machine__create_kernel_maps(machine);
}
-static int hex(char ch)
-{
- if ((ch >= '0') && (ch <= '9'))
- return ch - '0';
- if ((ch >= 'a') && (ch <= 'f'))
- return ch - 'a' + 10;
- if ((ch >= 'A') && (ch <= 'F'))
- return ch - 'A' + 10;
- return -1;
-}
-
/*
* While we find nice hex chars, build a long_val.
* Return number of chars processed.
*/
int hex2u64(const char *ptr, u64 *long_val)
{
- const char *p = ptr;
- *long_val = 0;
-
- while (*p) {
- const int hex_val = hex(*p);
+ char *p;
- if (hex_val < 0)
- break;
-
- *long_val = (*long_val << 4) | hex_val;
- p++;
- }
+ *long_val = strtoull(ptr, &p, 16);
return p - ptr;
}
--
1.7.10.4
prev parent reply other threads:[~2012-08-08 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 15:05 [PATCH] tools/perf: fix build when WERROR=1 Andy Shevchenko
2012-08-08 16:18 ` Arnaldo Carvalho de Melo
2012-08-08 16:32 ` Andy Shevchenko
2012-08-08 16:38 ` Arnaldo Carvalho de Melo
2012-08-08 16:47 ` Andy Shevchenko
2012-08-08 17:09 ` Arnaldo Carvalho de Melo
2012-08-08 16:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344443846-5594-1-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux$(echo .)intel.com \
--cc=acme@ghostprotocols$(echo .)net \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox