From: Maxim Levitsky <maximlevitsky@gmail•com>
To: Geert Uytterhoeven <geert@linux-m68k•org>
Cc: Andrew Morton <akpm@linux-foundation•org>,
Alex Dubov <oakad@yahoo•com>,
linux-kernel@vger•kernel.org, Tejun Heo <tj@kernel•org>,
Linux-Next <linux-next@vger•kernel.org>
Subject: Re: [PATCH 2/2] memstick: add support for legacy memorysticks
Date: Mon, 01 Oct 2012 22:24:24 +0200 [thread overview]
Message-ID: <1349123064.29081.0.camel@maxim-laptop> (raw)
In-Reply-To: <CAMuHMdW7zfM1CxkXTCq2=ErkaAAxGVFyQSZdH3jwvUXr_8oOsg@mail.gmail.com>
On Sat, 2012-09-29 at 19:20 +0200, Geert Uytterhoeven wrote:
> On Wed, Sep 26, 2012 at 11:49 AM, Maxim Levitsky
> <maximlevitsky@gmail•com> wrote:
> > --- /dev/null
> > +++ b/drivers/memstick/core/ms_block.c
>
> > +#define pr_fmt(fmt) DRIVER_NAME ": " fmt
> > +
> > +#include <linux/module.h>
> > +#include <linux/blkdev.h>
> > +#include <linux/memstick.h>
> > +#include <linux/idr.h>
> > +#include <linux/hdreg.h>
> > +#include <linux/delay.h>
> > +#include <linux/slab.h>
> > +#include <linux/random.h>
> > +#include <linux/bitmap.h>
> > +#include <linux/scatterlist.h>
> > +#include <linux/jiffies.h>
> > +#include <linux/workqueue.h>
> > +#include <linux/mutex.h>
> > +#include "ms_block.h"
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/7280352/
> arch/m68k/include/asm/hardirq.h:23:20: error: expected ')' before 'DRIVER_NAME'
> make[4]: *** [drivers/memstick/core/ms_block.o] Error 1
>
> The reason for this is that pr_fmt() references DRIVER_NAME and is defined
> before the first include, while DRIVER_NAME is only defined in ms_block.h,
> which is the last included file. If any subsequent include file uses pr_fmt()
> (e.g. the call to pr_crit() in arch/m68k/include/asm/hardirq.h), this
> causes a build
> failure.
>
> I suggest moving the DRIVER_NAME define to ms_block.c.
> Cfr. memstick.c and mspro_block.c, who already have their own definition.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k•org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Completely agree!
I was somewhat busy lately, so I didn't address this yet.
I'll send a patch tomorrow.
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2012-10-01 20:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1348652941-31899-1-git-send-email-maximlevitsky@gmail.com>
[not found] ` <1348652941-31899-3-git-send-email-maximlevitsky@gmail.com>
2012-09-29 17:20 ` [PATCH 2/2] memstick: add support for legacy memorysticks Geert Uytterhoeven
2012-10-01 20:24 ` Maxim Levitsky [this message]
2012-10-08 15:36 ` Fixes for ms_block Maxim Levitsky
2012-10-08 15:36 ` [PATCH 1/2] memstick: remove unused field from state struct Maxim Levitsky
2012-10-08 15:36 ` [PATCH 2/2] memstick: ms_block: fix complile issue Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349123064.29081.0.camel@maxim-laptop \
--to=maximlevitsky@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=geert@linux-m68k$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=oakad@yahoo$(echo .)com \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox