From: Eric Dumazet <eric.dumazet@gmail•com>
To: Michael Neuling <mikey@neuling•org>
Cc: Eric Dumazet <edumazet@google•com>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Maxime Bizon <mbizon@freebox•fr>,
"David S. Miller" <davem@davemloft•net>,
linuxppc-dev@ozlabs•org
Subject: Re: net: fix typo in freescale/ucc_geth.c
Date: Tue, 09 Oct 2012 08:04:39 +0200 [thread overview]
Message-ID: <1349762679.21172.3842.camel@edumazet-glaptop> (raw)
In-Reply-To: <23452.1349740345@neuling.org>
On Tue, 2012-10-09 at 10:52 +1100, Michael Neuling wrote:
> The following patch:
> acb600d net: remove skb recycling
> added dev_free_skb() to drivers/net/ethernet/freescale/ucc_geth.c
>
> This is a typo and should be dev_kfree_skb(). This fixes this.
>
> Signed-off-by: Michael Neuling <mikey@neuling•org>
> ---
> This hit as a compile error in next-20121008 with mpc85xx_defconfig.
>
> diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
> index dfa0aaa..0a70bb5 100644
> --- a/drivers/net/ethernet/freescale/ucc_geth.c
> +++ b/drivers/net/ethernet/freescale/ucc_geth.c
> @@ -3268,7 +3268,7 @@ static int ucc_geth_rx(struct ucc_geth_private *ugeth, u8 rxQ, int rx_work_limit
> if (netif_msg_rx_err(ugeth))
> ugeth_err("%s, %d: ERROR!!! skb - 0x%08x",
> __func__, __LINE__, (u32) skb);
> - dev_free_skb(skb);
> + dev_kfree_skb(skb);
>
> ugeth->rx_skbuff[rxQ][ugeth->skb_currx[rxQ]] = NULL;
>
Oops, thanks Michael !
prev parent reply other threads:[~2012-10-09 6:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 6:36 linux-next: Tree for Oct 8 Stephen Rothwell
2012-10-08 23:52 ` net: fix typo in freescale/ucc_geth.c Michael Neuling
2012-10-09 4:21 ` David Miller
2012-10-09 6:04 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349762679.21172.3842.camel@edumazet-glaptop \
--to=eric.dumazet@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mbizon@freebox$(echo .)fr \
--cc=mikey@neuling$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox