public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Sedat Dilek <sedat.dilek@gmail•com>
To: David Howells <dhowells@redhat•com>,
	Rusty Russell <rusty@rustcorp•com.au>,
	linux-kernel@vger•kernel.org, linux-next@vger•kernel.org,
	Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Sedat Dilek <sedat.dilek@gmail•com>
Subject: [PATCH next-20130118 1/2] KEYS: Fix build-error when SYSTEM_TRUSTED_KEYRING=n
Date: Sat, 19 Jan 2013 01:54:30 +0100	[thread overview]
Message-ID: <1358556871-6651-1-git-send-email-sedat.dilek@gmail.com> (raw)

When SYSTEM_TRUSTED_KEYRING=n my build fails like this:

kernel/module_signing.c: In function 'request_asymmetric_key':
kernel/module_signing.c:161:36: error: 'system_trusted_keyring' undeclared (first use in this function)
kernel/module_signing.c:161:36: note: each undeclared identifier is reported only once for each function it appears in

Fix this by replacing "select" with "depends on" KEYS Kconfig.

For more details follow the thread in [1].

[1] http://marc.info/?t=135854545000001&r=1&w=2

Tested against Linux-Next (next-20130118).

Signed-off-by: Sedat Dilek <sedat.dilek@gmail•com>
---
 init/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/init/Kconfig b/init/Kconfig
index fb2959d..f7e1b32 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1607,7 +1607,7 @@ config BASE_SMALL
 
 config SYSTEM_TRUSTED_KEYRING
 	bool "Provide system-wide ring of trusted keys"
-	select KEYS
+	depends on KEYS
 	help
 	  Provide a system keyring to which trusted keys can be added.  Keys in
 	  the keyring are considered to be trusted.  Keys may be added at will
-- 
1.8.1.1

             reply	other threads:[~2013-01-19  0:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-19  0:54 Sedat Dilek [this message]
2013-01-19  0:54 ` [PATCH next-20130118 2/2] KEYS: MODSIGN: Fix wrong select in MODULE_SIG Kconfig Sedat Dilek
2013-01-19  1:07 ` [PATCH next-20130118 1/2] KEYS: Fix build-error when SYSTEM_TRUSTED_KEYRING=n David Howells
2013-01-19  1:13   ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358556871-6651-1-git-send-email-sedat.dilek@gmail.com \
    --to=sedat.dilek@gmail$(echo .)com \
    --cc=dhowells@redhat$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=rusty@rustcorp$(echo .)com.au \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox