From: Peter Huewe <peterhuewe@gmx•de>
To: Randy Dunlap <rdunlap@infradead•org>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org,
Yunhong Jiang <yunhong.jiang@intel•com>,
Sheng Yang <sheng@linux•intel.com>,
"Mike A. Chan" <mikechan@google•com>,
Xiaohui Xin <xiaohui.xin@intel•com>,
devel@driverdev•osuosl.org, linux-kernel@vger•kernel.org,
Peter Huewe <peterhuewe@gmx•de>
Subject: [PATCH] staging/goldfish: Add MTD dependency to KCONFIG
Date: Thu, 7 Feb 2013 23:46:38 +0100 [thread overview]
Message-ID: <1360277198-18246-1-git-send-email-peterhuewe@gmx.de> (raw)
In-Reply-To: <5113FAAE.4070501@infradead.org>
If CONFIG_MTD is not set goldfish_nand fails to compile with the
following linker warnings:
drivers/built-in.o: In function `goldfish_nand_remove':
goldfish_nand.c:(.text+0x6e7d0e): undefined reference to
`mtd_device_unregister'
drivers/built-in.o: In function `goldfish_nand_erase':
goldfish_nand.c:(.text+0x6e8ba2): undefined reference to
`mtd_erase_callback'
drivers/built-in.o: In function `goldfish_nand_init_device':
goldfish_nand.c:(.text+0x6e8eba): undefined reference to
`mtd_device_parse_register'
Reported-by: Randy Dunlap <rdunlap@infradead•org>
Signed-off-by: Peter Huewe <peterhuewe@gmx•de>
---
@Randy: The contact info you're looking for is in CC of this mail.
drivers/staging/goldfish/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/goldfish/Kconfig b/drivers/staging/goldfish/Kconfig
index d6c98d0..4e09460 100644
--- a/drivers/staging/goldfish/Kconfig
+++ b/drivers/staging/goldfish/Kconfig
@@ -7,6 +7,7 @@ config GOLDFISH_AUDIO
config MTD_GOLDFISH_NAND
tristate "Goldfish NAND device"
depends on GOLDFISH
+ depends on MTD
help
Drives the emulated NAND flash device on the Google Goldfish
Android virtual device.
--
1.7.8.6
prev parent reply other threads:[~2013-02-07 22:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 6:37 linux-next: Tree for Feb 7 Stephen Rothwell
2013-02-07 18:45 ` linux-next: Tree for Feb 7 (drivers/misc/mei) Randy Dunlap
2013-02-07 19:04 ` linux-next: Tree for Feb 7 (staging/goldfish) Randy Dunlap
2013-02-07 22:46 ` Peter Huewe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360277198-18246-1-git-send-email-peterhuewe@gmx.de \
--to=peterhuewe@gmx$(echo .)de \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mikechan@google$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=sheng@linux$(echo .)intel.com \
--cc=xiaohui.xin@intel$(echo .)com \
--cc=yunhong.jiang@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox