Subject: Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

From: "Nicholas A. Bellinger" <[email-masked]>
Date: Tue, 14 May 2013 20:10:20 -0700

On Wed, 2013-05-15 at 08:59 +0800, Asias He wrote:
> scsi.c includes vhost.c which uses memcpy_fromiovec.
> 
> This patch fixes this build failure.
> 
>    From Randy Dunlap:
>    '''
>    on x86_64:
> 
>    ERROR: "memcpy_fromiovec" [drivers/vhost/vhost_scsi.ko] undefined!
> 
>    It needs to depend on NET since net/core/ provides that function.
>    '''
> 
> Reported-by: Randy Dunlap <[email-masked]>
> Signed-off-by: Asias He <[email-masked]>

Hey Asias & MST,

FYI, I'll be sending a PULL request to Linus in the next couple of days
for -rc2.

Let me know if you'd like this to be picked up.

--nab

> ---
>  drivers/vhost/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig
> index 8b9226d..0403323 100644
> --- a/drivers/vhost/Kconfig
> +++ b/drivers/vhost/Kconfig
> @@ -12,7 +12,7 @@ config VHOST_NET
>  
>  config VHOST_SCSI
>  	tristate "VHOST_SCSI TCM fabric driver"
> -	depends on TARGET_CORE && EVENTFD && m
> +	depends on NET && TARGET_CORE && EVENTFD && m
>  	select VHOST_RING
>  	default n
>  	---help---