From: "Nicholas A. Bellinger" <nab@linux-iscsi•org>
To: Randy Dunlap <rdunlap@infradead•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
target-devel <target-devel@vger•kernel.org>,
kmo@daterainc•com, Tejun Heo <tj@kernel•org>
Subject: Re: linux-next: Tree for Nov 15 (target_core_mod)
Date: Tue, 19 Nov 2013 15:12:38 -0800 [thread overview]
Message-ID: <1384902758.4307.25.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <528BA90D.5070009@infradead.org>
On Tue, 2013-11-19 at 10:08 -0800, Randy Dunlap wrote:
> On 11/18/13 11:46, Nicholas A. Bellinger wrote:
<SNIP>
>
> That does fix the build errors. Thanks.
>
> Here is a more complete patch with a patch description and S-O-B.
> I would have put your S-O-B in it but you didn't include one.
> Feel free to add yours now.
>
> ---
> From: Randy Dunlap <rdunlap@infradead•org>
>
> Drop percpu_ida.o from lib-y since it is also listed in obj-y
> and it doesn't need to be listed in both places.
>
> Move percpu-refcount.o from lib-y to obj-y to fix build errors
> in target_core_mod:
>
> ERROR: "percpu_ref_cancel_init" [drivers/target/target_core_mod.ko] undefined!
> ERROR: "percpu_ref_kill_and_confirm" [drivers/target/target_core_mod.ko] undefined!
> ERROR: "percpu_ref_init" [drivers/target/target_core_mod.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead•org>
Hi Randy,
Applied.
Thanks!
--nab
> ---
> lib/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20131115.orig/lib/Makefile
> +++ linux-next-20131115/lib/Makefile
> @@ -13,7 +13,7 @@ lib-y := ctype.o string.o vsprintf.o cmd
> sha1.o md5.o irq_regs.o reciprocal_div.o argv_split.o \
> proportions.o flex_proportions.o prio_heap.o ratelimit.o show_mem.o \
> is_single_threaded.o plist.o decompress.o kobject_uevent.o \
> - earlycpio.o percpu-refcount.o percpu_ida.o
> + earlycpio.o
>
> obj-$(CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS) += usercopy.o
> lib-$(CONFIG_MMU) += ioremap.o
> @@ -26,7 +26,7 @@ obj-y += bcd.o div64.o sort.o parser.o h
> bust_spinlocks.o hexdump.o kasprintf.o bitmap.o scatterlist.o \
> gcd.o lcm.o list_sort.o uuid.o flex_array.o iovec.o clz_ctz.o \
> bsearch.o find_last_bit.o find_next_bit.o llist.o memweight.o kfifo.o \
> - percpu_ida.o
> + percpu-refcount.o percpu_ida.o
> obj-y += string_helpers.o
> obj-$(CONFIG_TEST_STRING_HELPERS) += test-string_helpers.o
> obj-y += kstrtox.o
> --
> To unsubscribe from this list: send the line "unsubscribe target-devel" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-11-19 23:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 5:24 linux-next: Tree for Nov 15 Stephen Rothwell
2013-11-15 17:41 ` linux-next: Tree for Nov 15 (target_core_mod) Randy Dunlap
2013-11-18 19:46 ` Nicholas A. Bellinger
2013-11-19 18:08 ` Randy Dunlap
2013-11-19 23:12 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384902758.4307.25.camel@haakon3.risingtidesystems.com \
--to=nab@linux-iscsi$(echo .)org \
--cc=kmo@daterainc$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rdunlap@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=target-devel@vger$(echo .)kernel.org \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox