From: David Howells <dhowells@redhat•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>, B04825@freescale•com
Cc: dhowells@redhat•com, Alexander Graf <agraf@suse•de>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Liu Yu <yu.liu@freescale•com>,
Stuart Yoder <stuart.yoder@freescale•com>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: linux-next: manual merge of the kvm-ppc tree with the powerpc-merge tree
Date: Thu, 11 Oct 2012 10:27:00 +0100 [thread overview]
Message-ID: <13876.1349947620@warthog.procyon.org.uk> (raw)
In-Reply-To: <20121011120502.0211f1267dedf3776e4cf85b@canb.auug.org.au>
Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> I just removed epapr_hcalls.h from the Kbuild file as I am not sure how
> it should be broken up. David, can you have a look at this, please?
Files should be broken up along around __KERNEL__ conditionals. If there are
no __KERNEL__ conditionals, it is assumed that the file is entirely UAPI and
can just be moved.
The problem appears to be this commit:
https://github.com/agraf/linux-2.6/commit/4c09029a5639c955fcf6d65205796e4f1208aed3
From: Liu Yu <yu.liu@freescale•com>
Subject: KVM: PPC: Add support for ePAPR idle hcall in host kernel
Just makes epapr_hcalls.h part of the userspace API in its entirety by this bit
of the patch:
+header-y += epapr_hcalls.h
whilst not adding any __KERNEL__ guards - which is almost certainly incorrect.
At the very least, I would say that the global variable declarations need
limiting to kernel space, and thus so do the inline functions as they emit
inline assembly to jump somewhere specified by one of the global variables
(actually a code array).
So for manual splitting purposes, I would go with just moving all the #defines
prior to the __ASSEMBLY__ guard out to uapi. Everything within the
__ASSEMBLY__ guard is KABI only by the looks of it.
David
next prev parent reply other threads:[~2012-10-11 9:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 1:05 linux-next: manual merge of the kvm-ppc tree with the powerpc-merge tree Stephen Rothwell
2012-10-11 9:27 ` David Howells [this message]
2012-10-11 13:08 ` Alexander Graf
2012-10-11 16:05 ` David Howells
-- strict thread matches above, loose matches on Subject: below --
2012-10-11 1:18 Stephen Rothwell
2012-10-11 1:47 ` Tabi Timur-B04825
2012-10-11 2:47 ` Stephen Rothwell
2012-10-11 3:32 ` Tabi Timur-B04825
2012-10-11 13:04 ` Alexander Graf
2012-10-11 15:50 ` Scott Wood
2012-10-11 15:56 ` Alexander Graf
2012-10-11 16:33 ` Scott Wood
2012-10-11 15:55 ` Timur Tabi
2012-10-11 16:37 ` Scott Wood
2012-10-11 17:24 ` Timur Tabi
2012-10-11 17:28 ` Scott Wood
2012-10-11 17:30 ` Timur Tabi
2012-10-11 9:28 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13876.1349947620@warthog.procyon.org.uk \
--to=dhowells@redhat$(echo .)com \
--cc=B04825@freescale$(echo .)com \
--cc=agraf@suse$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=stuart.yoder@freescale$(echo .)com \
--cc=yu.liu@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox