From: Paul Gortmaker <paul.gortmaker@windriver•com>
To: linux-kernel@vger•kernel.org
Cc: sparclinux@vger•kernel.org, linux-next@vger•kernel.org,
Paul Gortmaker <paul.gortmaker@windriver•com>,
Jiri Kosina <jkosina@suse•cz>,
Thomas Gleixner <tglx@linutronix•de>,
stable@vger•kernel.org
Subject: [PATCH] irqdesc: Fix missing irq_to_desc export for !CONFIG_SPARSE_IRQ
Date: Mon, 10 Feb 2014 13:39:53 -0500 [thread overview]
Message-ID: <1392057610-11514-1-git-send-email-paul.gortmaker@windriver.com> (raw)
In allmodconfig builds for sparc and any other arch which does
not set CONFIG_SPARSE_IRQ, the following will be seen at modpost:
CC [M] lib/cpu-notifier-error-inject.o
CC [M] lib/pm-notifier-error-inject.o
ERROR: "irq_to_desc" [drivers/gpio/gpio-mcp23s08.ko] undefined!
make[2]: *** [__modpost] Error 1
This happens because commit 3911ff30f5d1175e2e67e73244405e3492b35c79
("genirq: export handle_edge_irq() and irq_to_desc()") added one
export for it, but there were actually two instances of it, in
an if/else clause for CONFIG_SPARSE_IRQ. Add the second one.
Cc: Jiri Kosina <jkosina@suse•cz>
Cc: Thomas Gleixner <tglx@linutronix•de>
Cc: stable@vger•kernel.org # 3.4+
Fixes: 3911ff30f5d1 ("genirq: export handle_edge_irq() and irq_to_desc()")
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 192a302d6cfd..8ab8e9390297 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -274,6 +274,7 @@ struct irq_desc *irq_to_desc(unsigned int irq)
{
return (irq < NR_IRQS) ? irq_desc + irq : NULL;
}
+EXPORT_SYMBOL(irq_to_desc);
static void free_desc(unsigned int irq)
{
--
1.8.5.2
reply other threads:[~2014-02-10 18:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392057610-11514-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver$(echo .)com \
--cc=jkosina@suse$(echo .)cz \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox