From: Markos Chandras <markos.chandras@imgtec•com>
To: linux-mips@linux-mips•org
Cc: Markos Chandras <markos.chandras@imgtec•com>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: [PATCH v2] samples/seccomp/Makefile: Do not build tests if cross-compiling for MIPS
Date: Wed, 19 Feb 2014 10:15:17 +0000 [thread overview]
Message-ID: <1392804917-29789-1-git-send-email-markos.chandras@imgtec.com> (raw)
In-Reply-To: <52FD0131.9040304@imgtec.com>
The Makefile is designed to use the host toolchain so it may be
unsafe to build the tests if the kernel has been configured and built
for another architecture. This fixes a build problem when the kernel has
been configured and built for the MIPS architecture but the host is
not MIPS (cross-compiled). The MIPS syscalls are only defined
if one of the following is true:
1) _MIPS_SIM == _MIPS_SIM_ABI64
2) _MIPS_SIM == _MIPS_SIM_ABI32
3) _MIPS_SIM == _MIPS_SIM_NABI32
Of course, none of these make sense on a non-MIPS toolchain and the
following build problem occurs when building on a non-MIPS host.
linux/usr/include/linux/kexec.h:50:
userspace cannot reference function or variable defined in the kernel
samples/seccomp/bpf-direct.c: In function ‘emulator’:
samples/seccomp/bpf-direct.c:76:17: error:
‘__NR_write’ undeclared (first use in this function)
Cc: linux-next@vger•kernel.org
Cc: linux-kernel@vger•kernel.org
Reported-by: Paul Gortmaker <paul.gortmaker@windriver•com>
Signed-off-by: Markos Chandras <markos.chandras@imgtec•com>
---
This build problem is only reproducible on the linux-next tree at the moment
Changes since v1:
- Rework code so native builds are allowed on MIPS
---
samples/seccomp/Makefile | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/samples/seccomp/Makefile b/samples/seccomp/Makefile
index 7203e66..855051b 100644
--- a/samples/seccomp/Makefile
+++ b/samples/seccomp/Makefile
@@ -18,8 +18,8 @@ HOSTCFLAGS_bpf-direct.o += -idirafter $(objtree)/include
bpf-direct-objs := bpf-direct.o
# Try to match the kernel target.
-ifndef CONFIG_64BIT
ifndef CROSS_COMPILE
+ifndef CONFIG_64BIT
# s390 has -m31 flag to build 31 bit binaries
ifndef CONFIG_S390
@@ -36,7 +36,13 @@ HOSTLOADLIBES_bpf-direct += $(MFLAG)
HOSTLOADLIBES_bpf-fancy += $(MFLAG)
HOSTLOADLIBES_dropper += $(MFLAG)
endif
-endif
-
-# Tell kbuild to always build the programs
always := $(hostprogs-y)
+else
+# MIPS system calls are defined based on the -mabi that is passed
+# to the toolchain which may or may not be a valid option
+# for the host toolchain. So disable tests if target architecture
+# is MIPS but the host isn't.
+ifndef CONFIG_MIPS
+always := $(hostprogs-y)
+endif
+endif
--
1.9.0
next prev parent reply other threads:[~2014-02-19 10:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 17:27 [PATCH] samples/seccomp/Makefile: Do not build tests if cross-compiling for MIPS Markos Chandras
2014-02-13 17:30 ` Markos Chandras
2014-02-19 10:15 ` Markos Chandras [this message]
2014-03-12 11:22 ` [PATCH v2] " Markos Chandras
2014-02-13 18:30 ` [PATCH] " David Daney
2014-02-14 1:33 ` Paul Gortmaker
2014-02-17 13:22 ` Markos Chandras
2014-02-19 4:21 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392804917-29789-1-git-send-email-markos.chandras@imgtec.com \
--to=markos.chandras@imgtec$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox