From: Scott Wood <scottwood@freescale•com>
To: Paul Gortmaker <paul.gortmaker@windriver•com>
Cc: Arnd Bergmann <arnd@arndb•de>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
linux-next@vger•kernel.org, Paul Mackerras <paulus@samba•org>,
linuxppc-dev@lists•ozlabs.org,
Prabhakar Kushwaha <prabhakar@freescale•com>
Subject: Re: [PATCH] powerpc: select MEMORY for FSL_IFC to not break existing .config files
Date: Wed, 19 Feb 2014 16:19:10 -0600 [thread overview]
Message-ID: <1392848350.6733.809.camel@snotra.buserror.net> (raw)
In-Reply-To: <1392847641-63777-1-git-send-email-paul.gortmaker@windriver.com>
On Wed, 2014-02-19 at 17:07 -0500, Paul Gortmaker wrote:
> commit d2ae2e20fbdde5a65f3a5a153044ab1e5c53f7cc ("driver/memory:Move
> Freescale IFC driver to a common driver") introduces this build
> regression into the mpc85xx_defconfig:
>
> drivers/built-in.o: In function `fsl_ifc_nand_remove':
> drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference to `fsl_ifc_ctrl_dev'
> drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference to `fsl_ifc_ctrl_dev'
> drivers/built-in.o: In function `fsl_ifc_nand_probe':
> drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference to `fsl_ifc_ctrl_dev'
> drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference to `fsl_ifc_ctrl_dev'
> drivers/built-in.o: In function `match_bank':
> drivers/mtd/nand/fsl_ifc_nand.c:1013: undefined reference to `convert_ifc_address'
> drivers/built-in.o: In function `fsl_ifc_nand_probe':
> drivers/mtd/nand/fsl_ifc_nand.c:1059: undefined reference to `fsl_ifc_ctrl_dev'
> drivers/mtd/nand/fsl_ifc_nand.c:1080: undefined reference to `fsl_ifc_ctrl_dev'
> drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference to `fsl_ifc_ctrl_dev'
> drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference to `fsl_ifc_ctrl_dev'
> make: *** [vmlinux] Error 1
>
> This happens because there is nothing to descend us into the
> drivers/memory directory in the mpc85xx_defconfig. It wasn't
> selecting CONFIG_MEMORY. So we never built drivers/memory/fsl_ifc.o
> even with CONFIG_FSL_IFC=y, and so we have nothing to link against.
>
> In order to remain compatible with old config files and to avoid
> such build failures, make CONFIG_FSL_IFC select CONFIG_MEMORY.
> Also fix the whitespace issue (spaces vs. a tab) in the Kconfig.
>
> Cc: Prabhakar Kushwaha <prabhakar@freescale•com>
> Cc: Arnd Bergmann <arnd@arndb•de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
> ---
>
> [This probably makes sense to go in via Greg's char-misc/char-misc-next
> (vs. powerpc-next) since that is where the regression was introduced.]
>
> arch/powerpc/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 957bf344c0f5..d2d8d8f50610 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -738,7 +738,8 @@ config FSL_LBC
>
> config FSL_IFC
> bool
> - depends on FSL_SOC
> + depends on FSL_SOC
> + select MEMORY
Why do we still have FSL_IFC in arch/powerpc/Kconfig if the driver has
been moved? The NAND driver and other selectors of FSL_IFC can select
MEMORY.
-Scott
next prev parent reply other threads:[~2014-02-19 22:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 22:07 [PATCH] powerpc: select MEMORY for FSL_IFC to not break existing .config files Paul Gortmaker
2014-02-19 22:19 ` Scott Wood [this message]
2014-02-19 22:25 ` Paul Gortmaker
2014-02-19 22:46 ` [PATCH v2] " Paul Gortmaker
2014-02-20 6:05 ` Prabhakar Kushwaha
2014-02-20 14:40 ` Paul Gortmaker
2014-02-21 4:00 ` Prabhakar Kushwaha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392848350.6733.809.camel@snotra.buserror.net \
--to=scottwood@freescale$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=prabhakar@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox