From: Paul Gortmaker <paul.gortmaker@windriver•com>
To: linux-kernel@vger•kernel.org
Cc: linux-next@vger•kernel.org,
Paul Gortmaker <paul.gortmaker@windriver•com>,
Johannes Thumshirn <johannes.thumshirn@men•de>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>
Subject: [PATCH-next] drivers/mcb: do not set default Kconfig variable to modular
Date: Wed, 5 Mar 2014 19:38:09 -0500 [thread overview]
Message-ID: <1394066289-18320-1-git-send-email-paul.gortmaker@windriver.com> (raw)
Coverage builds found this build fail in ARM ebsa110_defconfig:
drivers/mcb/mcb-parse.c: In function 'chameleon_parse_cells':
drivers/mcb/mcb-parse.c:105:2: error: implicit declaration of function 'memcpy_fromio' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[2]: *** [drivers/mcb/mcb-parse.o] Error 1
A simple bisect will output this:
3764e82e5150d87b205c10cd78a9c9ab86fbfa51 is the first bad commit
commit 3764e82e5150d87b205c10cd78a9c9ab86fbfa51
Author: Johannes Thumshirn <johannes.thumshirn@men•de>
Date: Wed Feb 26 17:29:05 2014 +0100
drivers: Introduce MEN Chameleon Bus
The above commit used "default m" which is wrong. New drivers
should never be globally enabled with "default y/m". Whether
this driver makes sense to build on ARM is an independent issue.
Here we delete the "default m" line, which is the equivalent of
"default n".
Cc: Johannes Thumshirn <johannes.thumshirn@men•de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
---
[above commit ID comes from char-misc tree, and will be invalid
if that content gets rebased... ]
drivers/mcb/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mcb/Kconfig b/drivers/mcb/Kconfig
index 44c82d68c563..9ad2f8661487 100644
--- a/drivers/mcb/Kconfig
+++ b/drivers/mcb/Kconfig
@@ -4,7 +4,6 @@
menuconfig MCB
tristate "MCB support"
- default m
help
The MCB (MEN Chameleon Bus) is a Bus specific to MEN Mikroelektronik
--
1.9.0
reply other threads:[~2014-03-06 0:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394066289-18320-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=johannes.thumshirn@men$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox