Subject: Re: linux-next: build failure after merge of the target-updates tree

From: "Nicholas A. Bellinger" <[email-masked]>
Date: Fri, 23 May 2014 10:38:37 -0700

Hi Stephen,

(Adding CC's for Paolo + MKP)

On Fri, 2014-05-23 at 19:11 +1000, Stephen Rothwell wrote:
> Hi Nicholas,
> 
> After merging the target-updates tree, today's linux-next build
> (powerpc ppc64_defconfig) failed like this:
> 
> 
> drivers/scsi/virtio_scsi.c: In function 'virtio_scsi_init_hdr_pi':
> drivers/scsi/virtio_scsi.c:491:48: error: dereferencing pointer to incomplete type
>    cmd_pi->pi_bytesout = blk_rq_sectors(rq) * bi->tuple_size;
>                                                 ^
> drivers/scsi/virtio_scsi.c:493:47: error: dereferencing pointer to incomplete type
>    cmd_pi->pi_bytesin = blk_rq_sectors(rq) * bi->tuple_size;
>                                                ^
> 
> Caused by commit 4baaa7d589e2 ("virtio-scsi: Enable DIF/DIX modes in
> SCSI host LLD").  A missing include of linux/blkdev.h.  See Rule 1 in
> Documentation/SubmitChecklist.
> 
> I have used the target-updates tree from next-20140522 for today.

Whoops, adding the missing #include <linux/blkdev.h> now..

Thanks!

--nab