From: "Alexander Shiyan" <shc_work@mail•ru>
To: "Tobias Klauser" <tklauser@distanz•ch>
Cc: "Jim Davis" <jim.epost@gmail•com>,
"Stephen Rothwell" <sfr@canb•auug.org.au>,
linux-next <linux-next@vger•kernel.org>,
linux-kernel <linux-kernel@vger•kernel.org>,
jslaby@suse•cz, linux-serial@vger•kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>
Subject: Re: [PATCH] tty: serial: serial_mctrl_gpio: Fix build error for !GPIOLIB
Date: Wed, 10 Sep 2014 18:36:09 +0400 [thread overview]
Message-ID: <1410359769.646202267@f334.i.mail.ru> (raw)
In-Reply-To: <20140910141621.GA4636@distanz.ch>
Wed, 10 Sep 2014 16:16:21 +0200 от Tobias Klauser <tklauser@distanz•ch>:
> On 2014-09-10 at 15:57:16 +0200, Greg Kroah-Hartman <gregkh@linuxfoundation•org> wrote:
> > On Wed, Sep 10, 2014 at 10:06:58AM +0200, Tobias Klauser wrote:
> > > If SERIAL_MCTRL_GPIO is selected but GPIOLIB is not, the noop functions
> > > from serial_mctrl_gpio.h are pulled in. However, serial_mctrl_gpio.c is
> > > still compiled, leading to function redefinition build errors. Since all
> > > drivers that include serial_mctrl_gpio.h also depend on
> > > SERIAL_MCTRL_GPIO, let it depend on GPIOLIB as well remove the noop
> > > functions alltogether.
> > >
> > > Reported-by: Jim Davis <jim.epost@gmail•com>
> > > Signed-off-by: Tobias Klauser <tklauser@distanz•ch>
> > > ---
> > > drivers/tty/serial/Kconfig | 1 +
> > > drivers/tty/serial/serial_mctrl_gpio.h | 35 ----------------------------------
> > > 2 files changed, 1 insertion(+), 35 deletions(-)
> >
> > I fixed this yesterday with commit below from Alexander, which does
> > things a bit differently than you. Any objections to it?
>
> This is nicer in terms of being able to compile the driver without
> GPIOLIB. However, it wont fix it for the other user of
> SERIAL_MCTRL_GPIO, namely SERIAL_ATMEL. And for any future users of
> SERIAL_MCTRL_GPIO, we need to make sure to use the same select
> directive. To fix it for atmel_serial, I'd suggest the patch below.
Atmel serial driver is already protected by ARCH_REQUIRE_GPIOLIB
in the architecture configuration. The error is happen only for COMPILE_TEST,
but for Atmel driver this option is disabled.
---
prev parent reply other threads:[~2014-09-10 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 22:32 randconfig build error with next-20140909, in drivers/tty/serial/serial_mctrl_gpio.c Jim Davis
2014-09-10 8:05 ` Tobias Klauser
2014-09-10 8:06 ` [PATCH] tty: serial: serial_mctrl_gpio: Fix build error for !GPIOLIB Tobias Klauser
2014-09-10 13:57 ` Greg Kroah-Hartman
2014-09-10 14:16 ` Tobias Klauser
2014-09-10 14:36 ` Alexander Shiyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410359769.646202267@f334.i.mail.ru \
--to=shc_work@mail$(echo .)ru \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jim.epost@gmail$(echo .)com \
--cc=jslaby@suse$(echo .)cz \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tklauser@distanz$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox