From: Andreas Ruprecht <rupran@einserver•de>
To: Mauro Carvalho Chehab <m.chehab@samsung•com>
Cc: linux-media@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-next@vger•kernel.org, sfr@canb•auug.org.au,
Andreas Ruprecht <rupran@einserver•de>
Subject: [PATCH v2] media: pci: smipcie: Fix dependency for DVB_SMIPCIE
Date: Fri, 21 Nov 2014 19:23:28 +0100 [thread overview]
Message-ID: <1416594208-29553-1-git-send-email-rupran@einserver.de> (raw)
In-Reply-To: <20141121161316.23963dc5@recife.lan>
In smipcie.c, the function i2c_bit_add_bus() is called. This
function is defined by the I2C bit-banging interfaces enabled
with CONFIG_I2C_ALGOBIT.
As there was no dependency in Kconfig, CONFIG_I2C_ALGOBIT could
be set to "m" while CONFIG_DVB_SMIPCIE was set to "y", resulting
in a build error due to an undefined reference.
This patch adds the dependency on CONFIG_I2C_ALGOBIT in Kconfig
by selecting it when CONFIG_DVB_SMIPCIE is selected.
Signed-off-by: Andreas Ruprecht <rupran@einserver•de>
Reported-by: Jim Davis <jim.epost@gmail•com>
---
drivers/media/pci/smipcie/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/pci/smipcie/Kconfig b/drivers/media/pci/smipcie/Kconfig
index 75a2992..57dd124 100644
--- a/drivers/media/pci/smipcie/Kconfig
+++ b/drivers/media/pci/smipcie/Kconfig
@@ -1,6 +1,7 @@
config DVB_SMIPCIE
tristate "SMI PCIe DVBSky cards"
depends on DVB_CORE && PCI && I2C
+ select I2C_ALGOBIT
select DVB_M88DS3103 if MEDIA_SUBDRV_AUTOSELECT
select MEDIA_TUNER_M88TS2022 if MEDIA_SUBDRV_AUTOSELECT
select MEDIA_TUNER_M88RS6000T if MEDIA_SUBDRV_AUTOSELECT
--
1.9.1
prev parent reply other threads:[~2014-11-21 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 17:51 [PATCH] media: pci: smipcie: Fix dependency for DVB_SMIPCIE Andreas Ruprecht
2014-11-21 18:13 ` Mauro Carvalho Chehab
2014-11-21 18:15 ` Andreas Ruprecht
2014-11-21 18:23 ` Andreas Ruprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416594208-29553-1-git-send-email-rupran@einserver.de \
--to=rupran@einserver$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=m.chehab@samsung$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox