From: Pierre-Louis Bossart <pierre-louis.bossart@linux•intel.com>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
Mark Brown <broonie@kernel•org>,
Liam Girdwood <lgirdwood@gmail•com>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Bard Liao <yung-chuan.liao@linux•intel.com>,
Daniel Baluta <daniel.baluta@nxp•com>
Subject: Re: linux-next: Fixes tags needs some work in the sound-asoc tree
Date: Thu, 16 Apr 2020 07:55:20 -0500 [thread overview]
Message-ID: <14195fe3-14b2-eb80-3409-f7ca817b95f5@linux.intel.com> (raw)
In-Reply-To: <20200416094111.3f37623f@canb.auug.org.au>
On 4/15/20 6:41 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 101001652ee7 ("ASoC: SOF: topology: fix: handle DAI widget connections properly with multiple CPU DAI's")
>
> Fixes tag
>
> Fixes: 4a7e26a4d833 ("ASoC: SOF: topology: connect dai widget to all
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: c59aca98c912 ("ASoC: SOF: topology: connect dai widget to all cpu-dais")
>
> Also, please do not split Fixes tags over more than one line and keep
> all the commit message tags together at the end of the commit message.
Sorry about that. I always run checkpatch.pl and didn't see an error
../patches/20200415/0001-ASoC-SOF-topology-fix-handle-DAI-widget-connections-.patch
-----------------------------------------------------------------------------------
total: 0 errors, 0 warnings, 0 checks, 49 lines checked
My theory is that the SHA1 check is fooled by our use of worktrees. This
SHA1 does exist but on another SOF development branch. Is there a way to
restrict the checks only to the base upstream branch, e.g. Mark's
for-5.8 branch?
If not, we probably need to make sure we have a separate directory just
for upstreaming, to avoid any pollution from SOF branches?
Thanks
-Pierre
next prev parent reply other threads:[~2020-04-16 16:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 23:41 linux-next: Fixes tags needs some work in the sound-asoc tree Stephen Rothwell
2020-04-16 12:55 ` Pierre-Louis Bossart [this message]
2020-04-16 13:09 ` Mark Brown
2020-04-22 7:27 ` Daniel Baluta
2020-04-22 7:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14195fe3-14b2-eb80-3409-f7ca817b95f5@linux.intel.com \
--to=pierre-louis.bossart@linux$(echo .)intel.com \
--cc=broonie@kernel$(echo .)org \
--cc=daniel.baluta@nxp$(echo .)com \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=yung-chuan.liao@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox